Support StringView and BinaryView in CDataInterface
#6171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
StringView and BinaryView in CDataInterface
alamb
approved these changes
Aug 2, 2024
| @@ -390,8 +390,10 @@ impl TryFrom<&FFI_ArrowSchema> for DataType { | |||
| "e" => DataType::Float16, | |||
| "f" => DataType::Float32, | |||
| "g" => DataType::Float64, | |||
| "vz" => DataType::BinaryView, | |||
There was a problem hiding this comment.
I wouble checked that vz and vu are the correct format strings: https://arrow.apache.org/docs/format/CDataInterface.html#data-type-description-format-strings ✅
|
This change will be included in #6016 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6170
Rationale for this change
Get C FFI schema conversions for view types working
What changes are included in this PR?
Implement conversions in C FFI for Utf8View and BinaryView
Are there any user-facing changes?
Schemas with views can now be serialized over the C FFI