Update object store MSRV to 1.64
#6123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jul 25, 2024
| @@ -24,7 +24,7 @@ readme = "README.md" | |||
| description = "A generic object store interface for uniformly interacting with AWS S3, Google Cloud Storage, Azure Blob Storage and local files." | |||
| keywords = ["object", "storage", "cloud"] | |||
| repository = "https://github.com/apache/arrow-rs/tree/master/object_store" | |||
| rust-version = "1.62.1" | |||
| rust-version = "1.64.0" | |||
There was a problem hiding this comment.
It appears we are using something that requires Rust 1.64: https://github.com/apache/arrow-rs/actions/runs/10099988786/job/27930338500?pr=6120
Since Rust 1.64 was released almost 2 years ago (September 2022) I think it is safe to upgrade
This reverts commit 7a4b760.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6122
Rationale for this change
Clippy found that some of our code actually requires
1.64so let's update Cargo to say thatWhat changes are included in this PR?
Update object store MSRV to
1.64Are there any user-facing changes?