Enable casting from Utf8View #6077
Conversation
arrow-cast/src/cast/string.rs
Outdated
| parse_string_iter::<P, _, _>(string_view_array.iter(), cast_options, || string_view_array.nulls().cloned()) | ||
| } | ||
|
|
||
| fn parse_string_iter<'a, P: Parser, I: Iterator<Item=Option<&'a str>>, F: FnOnce() -> Option<NullBuffer>>( |
There was a problem hiding this comment.
wanted to extract out the common functionality, could also be a macro if preferred
There was a problem hiding this comment.
Maybe we can use this trait: https://github.com/apache/arrow-rs/blob/master/arrow-string/src/like.rs#L158? Probably need to make it a public trait first.
|
This is ready for review, I've run |
|
Hm, I'm not sure what's up with the archery test, I'm seeing some connection denied after 10 minutes, I don't have permission to retrigger the check but I'm wondering if it's possibly a flake? |
Yes, I think it was a flake. Also once we have merged this PR I think your subsequent PRs will automatically start CI so we should be able to reduce the turnaround time on future PRs |
|
Thanks again @a10y |
|
Thanks for the quick reviews! |
Well, I am not sure I would call 2 days a quick review. One of my goals over the next few months is to grow the reviewer capacity in arrow-rs . |
Which issue does this PR close?
Closes #6076
Rationale for this change
See issue
What changes are included in this PR?
Mirroring of the existing Utf8 cast operations for Utf8View
Are there any user-facing changes?
Purely additive, this adds functionality for users that have Utf8View columns.