-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parquet): Implement AsyncFileWriter for object_store::buffered::BufWriter
#6013
Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
This PR is blocked by |
Thanks for the reminder @Xuanwo I filed this ticket to track the next release #6022 I looked at the commits that went into object_store: https://github.com/apache/arrow-rs/commits/master/object_store As of today there do not appear to be any breaking API changes to object store and thus I think we can release a minor 0.10.1 version |
Hi, @alamb, Sorry for the long waiting, this PR is ready to review now. |
object_store::buffered::BufWriter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Xuanwo this is looking great. I had a few documentation and API naming suggestions
Maybe we could add a mention of this ParquetObjectWriter
to the docs here too: https://docs.rs/parquet/latest/parquet/arrow/async_writer/index.html
Co-authored-by: Andrew Lamb <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Hi, @alamb, I have addressed all comments. PTAL, thanks! |
Signed-off-by: Xuanwo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Xuanwo -- this looks great to me 🙏
/// [`ParquetObjectWriter`] for writing to parquet to [`ObjectStore`] | ||
/// | ||
/// ``` | ||
/// # use arrow_array::{ArrayRef, Int64Array, RecordBatch}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ -- this is great -- thank you
Thanks again @Xuanwo |
Which issue does this PR close?
Closes #5766
Rationale for this change
Implement
AsyncFileWriter
forobject_store::buffered::BufWriter
What changes are included in this PR?
Add a new impl for
AsyncFileWriter
Are there any user-facing changes?
New impl added.