chore(5797): change default parquet data_page_row_limit to 20k #5957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
alamb
approved these changes
Jun 25, 2024
| @@ -37,6 +37,8 @@ pub const DEFAULT_COMPRESSION: Compression = Compression::UNCOMPRESSED; | |||
| pub const DEFAULT_DICTIONARY_ENABLED: bool = true; | |||
| /// Default value for [`WriterProperties::dictionary_page_size_limit`] | |||
| pub const DEFAULT_DICTIONARY_PAGE_SIZE_LIMIT: usize = DEFAULT_PAGE_SIZE; | |||
| /// Default value for [`WriterProperties::data_page_row_count_limit`] | |||
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5797
Rationale for this change
We have found evidence that setting this default lower improves the memory performance, and also makes parquet-rs consistent with the default used elsewhere (e.g. parquet-mr, iceberg).
What changes are included in this PR?
Sets a default of 20_000 rows.
Are there any user-facing changes?
There may be performance changes depending upon the user, but we anticipate it being an improvement and bring us into closer alignment.