like benchmark for StringView
#5936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 21, 2024
| ) | ||
| .unwrap() | ||
| }) | ||
| b.iter(|| eq(&scalar, &string_left).unwrap()) |
There was a problem hiding this comment.
this is a drive by cleanup to make the code neater
This was referenced Jun 21, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5374
Rationale for this change
Let's make some benchmarks for LIKE and StringViewArray so as we work on optimizations such as suggested by @wjones127 in #5931 (review) we can measure improvments
What changes are included in this PR?
Add benchmarks for like on StringViewArray
Are there any user-facing changes?
No, benchmarks only