Convert to local epoch when casting to timestamp without timezone #5831
Conversation
| assert!(result.is_null(2)); | ||
|
|
||
| let array = StringArray::from(vec!["2010-01-01T00:00:00.123456+08:00"]); |
There was a problem hiding this comment.
We now have a difference in behaviour here, which I think is kind of unfortunate - #4201 (comment)
There was a problem hiding this comment.
To keep the same behavior, would we have to change the string parsing logic too?
|
Hi @tustvold is this PR relevant for: apache/datafusion#12218 ? If so I would be happy to take over this to get it across the line. cc @alamb & @findepi |
Hi @devanbenz -- thanks for pinging. I think we need to come to some consensus / conclusion that this is the way we want to proceed. I believe there are still some unresolved questions on #5827 that need to be addressed (specifically I believe we also need to agree to update the textual parsing). Perhaps you can give #5827 a read and post a proposal there to make sure everyone is agreed |
Draft as I am not sure about this change
Which issue does this PR close?
Closes #5827
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?