Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Improve ArrowReaderBuilder::with_row_selection docs #5824

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 31, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

While working on apache/datafusion#10738 it was not entirely clear to me how the row selection interacted with the row group filtering. I think the documentation could be improved to make this more clear.

What changes are included in this PR?

Improve the documentation and add an example

Are there any user-facing changes?

Docs only, no code changes

@alamb alamb marked this pull request as ready for review May 31, 2024 17:26
@github-actions github-actions bot added the parquet Changes to the parquet crate label May 31, 2024
@alamb alamb added the documentation Improvements or additions to documentation label May 31, 2024
@tustvold tustvold merged commit fe071eb into apache:master Jun 2, 2024
16 checks passed
@alamb alamb deleted the alamb/row_selection_docs branch June 6, 2024 11:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants