Minor: Clarify docs on EnabledStatistics
#5812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
May 28, 2024
| /// Controls the level of statistics to be computed by the writer and stored in | ||
| /// the parquet file. | ||
| /// | ||
| /// Enabling statistics makes the resulting Parquet file larger and requires |
There was a problem hiding this comment.
I think it is useful to help people understand the implications of these settings as well so I tried to clarify the tradeoff here
tustvold
approved these changes
May 29, 2024
Co-authored-by: Raphael Taylor-Davies <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While working to add an example of pruning with these statistics in DataFusion apache/datafusion#10701 I ran across the term "chunk statistics"
I think from the context this means "column chunk" which would be good to clarify for the casual reader
What changes are included in this PR?
Are there any user-facing changes?
This is only a documentation change. There are no functional changes.