Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ffi): add run end encoded arrays #5632

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

notfilippo
Copy link
Contributor

Which issue does this PR close?

Closes #5631.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Apr 12, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this contribution @notfilippo 🙏

I think this is looking pretty close to mergeable, it just needs a test for nullable values.

I was hoping we could add an integration test to verify compatibility with the other arrow implementations https://github.com/apache/arrow-rs/blob/master/arrow-integration-testing/tests/ipc_reader.rs

However, I couldn't find any existing data file that has an REE array in it 🤔
https://github.com/apache/arrow-testing/tree/master/data/arrow-ipc-stream/integration/

arrow-schema/src/ffi.rs Show resolved Hide resolved
arrow/src/ffi.rs Show resolved Hide resolved
@notfilippo
Copy link
Contributor Author

I was hoping we could add an integration test to verify compatibility with the other arrow implementations https://github.com/apache/arrow-rs/blob/master/arrow-integration-testing/tests/ipc_reader.rs

However, I couldn't find any existing data file that has an REE array in it 🤔 https://github.com/apache/arrow-testing/tree/master/data/arrow-ipc-stream/integration/

Thanks, I can look into that as well

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you again @notfilippo

@tustvold tustvold merged commit 7d929f0 into apache:master Apr 15, 2024
25 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the "r+" datatype in the C Data interface / RunArray
3 participants