Minor: Add doc comments to GenericByteViewArray
#5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5374
Rationale for this change
#5481 added this new array type 🙏 @ariesdevil thank you.
It would be good to start making it easier to use with more documentation. Also I was in the middle of filing other tickets and I wanted a diagram to explain "garbage collection" in this context, so I figured I would also make a diagram for the main array types
What changes are included in this PR?
Add doc comments / ascii art to the
GenericByteViewArrayAre there any user-facing changes?
Only docs