Update latest chrono #5479
Merged
Update latest chrono #5479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
tustvold
commented
Mar 6, 2024
| @@ -1001,7 +1004,7 @@ impl Date32Type { | |||
| /// * `i` - The Date32Type to convert | |||
| pub fn to_naive_date(i: <Date32Type as ArrowPrimitiveType>::Native) -> NaiveDate { | |||
| let epoch = NaiveDate::from_ymd_opt(1970, 1, 1).unwrap(); | |||
| epoch.add(Duration::days(i as i64)) | |||
| epoch.add(Duration::try_days(i as i64).unwrap()) | |||
There was a problem hiding this comment.
Making these not panic is tracked by #4456
tustvold
commented
Mar 6, 2024
| @@ -130,45 +131,48 @@ pub fn time_to_time64ns(v: NaiveTime) -> i64 { | |||
| /// converts a `i64` representing a `timestamp(s)` to [`NaiveDateTime`] | |||
| #[inline] | |||
| pub fn timestamp_s_to_datetime(v: i64) -> Option<NaiveDateTime> { | |||
| NaiveDateTime::from_timestamp_opt(v, 0) | |||
| Some(DateTime::from_timestamp(v, 0)?.naive_utc()) | |||
There was a problem hiding this comment.
#5480 tracks cleaning up these APIs to return DateTime<Utc>
|
Merging this as the changes are mechanical and this is blocking the CI pipelines |
alamb
reviewed
Mar 7, 2024
| @@ -179,13 +183,13 @@ pub(crate) fn split_second(v: i64, base: i64) -> (i64, u32) { | |||
| /// converts a `i64` representing a `duration(s)` to [`Duration`] | |||
| #[inline] | |||
| pub fn duration_s_to_duration(v: i64) -> Duration { | |||
| Duration::seconds(v) | |||
| Duration::try_seconds(v).unwrap() | |||
There was a problem hiding this comment.
is there any performance implication here (e.g. starting to check for invalid durations when we didn't before)?
There was a problem hiding this comment.
No, it just moves the panic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
New chrono, new deprecations.
This just does the bare minimum to get the CI green, follow on work is tracked in #4456 and #5480
What changes are included in this PR?
Are there any user-facing changes?