Add Strongly Typed Array Slice (#3929) #3930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
changed the title
tustvold
force-pushed
the
add-primitive-array-slice
branch
from
e12f5b6
to
b725a19
Compare
tustvold
force-pushed
the
add-primitive-array-slice
branch
from
b725a19
to
18d14f8
Compare
alamb
approved these changes
Mar 28, 2023
This was referenced Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3880
Closes #3929
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
This is a breaking change, as calling
sliceon a concrete array will now return the concrete array. This change could be made as a non-breaking change, but I want to flush out the redundant downcasting.