replace from_timestamp by from_timestamp_opt
#2894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
avantgardnerio
approved these changes
Oct 19, 2022
Contributor
avantgardnerio
left a comment
avantgardnerio
left a comment
There was a problem hiding this comment.
Nice work staying ahead of chrono changes!
BTW when 0.4.23 is out, we can remove all our custom add_months code.
tustvold
approved these changes
Oct 20, 2022
Contributor
tustvold
left a comment
tustvold
left a comment
There was a problem hiding this comment.
This looks good to me, I think it would be good to document the circumstances these methods return None as it wasn't immediately obvious to me
alamb
changed the title
from_timestamp by from_timestamp_opt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2892
Rationale for this change
from_timestampinchronowill be deprecated in 0.4.23What changes are included in this PR?
Are there any user-facing changes?