Fix empty Schema::metadata deserialization error #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 5, 2021 21:37
alamb
approved these changes
May 5, 2021
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @hulunbier -- looks good to me. @nevi-me any concerns about this
nevi-me
approved these changes
May 7, 2021
Contributor
nevi-me
left a comment
nevi-me
left a comment
There was a problem hiding this comment.
No concerns @alamb, looks good. Thanks @hulunbier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope this fixes issue #241
Which issue does this PR close?
Closes #241
Rationale for this change
De-serializing schema with empty metadata gives us a "missing field metadata..." error, as stated in #241. returns an empty HashMap may be a better choice.
What changes are included in this PR?
Annotates field
Schema::metadatawith#[serde(default)], which will give us a empty HashMap if metadata is empty.Are there any user-facing changes?
none.