pin flatbuffers to 0.8.4 #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
approved these changes
Apr 29, 2021
Member
jorgecarleitao
left a comment
jorgecarleitao
left a comment
There was a problem hiding this comment.
Thanks a lot, @ritchie46 , for your fast response and fix 👍
Let's hope that this is temporary and flatbuffers addresses this on their side of things.
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
=======================================
Coverage 82.49% 82.49%
=======================================
Files 162 162
Lines 43621 43621
=======================================
Hits 35983 35983
Misses 7638 7638 Continue to review full report at Codecov.
|
ritchie46
force-pushed
the
fix_failing_build
branch
from
8f1a465 to
b2cffc1
Compare
alamb
approved these changes
Apr 29, 2021
Dandandan
approved these changes
Apr 29, 2021
Contributor
|
merging to get CI green |
Contributor
Author
|
Thanks for the quick merge on this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #238