Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DataType::equals_datatype method public, enabling other modules #1838

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Make DataType::equals_datatype method public, enabling other modules #1838

merged 1 commit into from
Jun 10, 2022

Conversation

nl5887
Copy link
Contributor

@nl5887 nl5887 commented Jun 10, 2022

This PR is working towards a fix for apache/datafusion#2326.

@nl5887
Make equals_datatype method public, enabling other modules
f2b2dd0 
* we'd like to use this function in datafusion
@nl5887
Copy link
Contributor Author

nl5887 commented Jun 10, 2022

@alamb

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1838 (f2b2dd0) into master (8d787d9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1838      +/-   ##
==========================================
- Coverage   83.48%   83.48%   -0.01%     
==========================================
  Files         201      201              
  Lines       56838    56838              
==========================================
- Hits        47452    47451       -1     
- Misses       9386     9387       +1
Impacted Files Coverage Δ
arrow/src/datatypes/datatype.rs 65.79% <100.00%> (ø)
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d787d9...f2b2dd0. Read the comment docs.

alamb
alamb approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @nl5887

@alamb alamb merged commit c6fac6d into apache:master Jun 10, 2022
@alamb alamb changed the title Make equals_datatype method public, enabling other modules Make DataType::equals_datatype method public, enabling other modules Jun 10, 2022
@alamb alamb added the enhancement Any new improvement worthy of a entry in the changelog label Jun 10, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nl5887 @codecov-commenter @alamb