Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Dec 4, 2021

Semi-manual cherry-pick of 5806d29

There were some conflicts I needed to handle manually (mostly related to f16 support which was added on master but is not semver backwards compatible so can't be backported)

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate parquet-derive labels Dec 4, 2021
@alamb alamb changed the base branch from master to active_release December 4, 2021 11:57
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2021

Codecov Report

Merging #1007 (de2f59c) into active_release (b4507f5) will increase coverage by 0.14%.
The diff coverage is 87.45%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           active_release    #1007      +/-   ##
==================================================
+ Coverage           82.34%   82.48%   +0.14%     
==================================================
  Files                 168      168              
  Lines               48832    49570     +738     
==================================================
+ Hits                40210    40890     +680     
- Misses               8622     8680      +58     
Impacted Files Coverage Δ
arrow/src/array/data.rs 82.04% <86.32%> (+1.32%) ⬆️
arrow/src/array/array_binary.rs 93.55% <100.00%> (+0.13%) ⬆️
arrow/src/array/array_dictionary.rs 88.75% <100.00%> (+0.28%) ⬆️
arrow/src/array/array_string.rs 97.08% <100.00%> (-0.83%) ⬇️
arrow/src/array/transform/mod.rs 85.33% <0.00%> (ø)
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (+0.22%) ⬆️
arrow/src/compute/kernels/comparison.rs 93.45% <0.00%> (+0.52%) ⬆️
arrow/src/buffer/mutable.rs 92.22% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4507f5...de2f59c. Read the comment docs.

* Add full data validation for ArrayData::try_new()

* Only look at offset+len indexes

Co-authored-by: Jörn Horstmann <git@jhorstmann.net>

* fix test

* fmt

* test for array indexes

Co-authored-by: Jörn Horstmann <git@jhorstmann.net>
@alamb alamb force-pushed the cherry_pick_5806d297 branch from 2f43802 to 14660d2 Compare December 5, 2021 14:08
@alamb alamb merged commit a92672e into active_release Dec 6, 2021
@alamb alamb deleted the cherry_pick_5806d297 branch December 7, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants