Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObjectStore] Non-Contiguous Write Payloads #5514

Closed
tustvold opened this issue Mar 14, 2024 · 0 comments · Fixed by #5538
Closed

[ObjectStore] Non-Contiguous Write Payloads #5514

tustvold opened this issue Mar 14, 2024 · 0 comments · Fixed by #5538
Assignees
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently ObjectStore::put accepts a Bytes object, which is a contiguous memory region. This is simple and efficient where payload sizes are known ahead of time, and buffers can therefore be sized appropriately up-front, however, it may force additional copies in situations where this is not known.

Describe the solution you'd like

I am not sure, the HTTP-based stores are fairly coupled to HTTP requests containing a Bytes body, and whilst reqwest does have the ability to wrap a byte stream, this would break retries, AWS content signing and possibly some other things.

Describe alternatives you've considered

With #5500 it becomes possible to do chunked writes with no additional copies, this potentially reduces the need for this functionality as users can just allocate data in 5 MiB chunks.

Additional context

#5500 adds a put_part API with a similar requirement

@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface labels Mar 14, 2024
@tustvold tustvold self-assigned this Mar 20, 2024
tustvold added a commit to tustvold/arrow-rs that referenced this issue Mar 21, 2024
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 4, 2024
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 4, 2024
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 9, 2024
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 9, 2024
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 9, 2024
@alamb alamb changed the title Non-Contiguous Write Payloads [ObjectStore] Non-Contiguous Write Payloads Apr 11, 2024
tustvold added a commit that referenced this issue Apr 15, 2024
* Support non-contiguous put payloads (#5514)

* Docs

* Add more docs

* Review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant