fix(local): prefix filtering with Path::prefix_matches #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LocalFileSystem backend incorrectly treated the prefix parameter as a directory path, walking only that specific directory instead of filtering results with prefix_matches. Changes: - Walk from parent directory instead of treating prefix as directory - Filter results using Path::prefix_matches - Handle special case: listing exact file path returns empty
Contributor
|
needs a clippy fix |
Contributor
|
All of these tests pass on current main, nor do I really understand what this PR is trying to fix? |
Contributor
|
Chalking this up as being AI slop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LocalFileSystem backend incorrectly treated the prefix parameter as a directory path, walking only that specific directory instead of filtering results with prefix_matches.
Changes:
Which issue does this PR close?
Fixes #573
Rationale for this change
So the backends work in a similar way.
What changes are included in this PR?
Are there any user-facing changes?