Conversation
Member
|
Thank you! This is all good from my end, but @assignUser if you have the bandwidth, could you take a look as well? |
Member
|
Merging for now, but I'm happy to follow-up with any edits! @m-kuhn Do you need a release to finish the vcpkg port? |
Member
|
Sorry I reviewed, lgtm. My review didn't go through for some reason :) |
Member
|
No worries! I just felt bad pinging you twice 🙂 |
Contributor
Author
|
No release needed, we can keep a patch in vcpkg and drop it on next update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures the proper target directories also on windows (
dlls tobin,libs tolib)