Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce automatic code formatting with JuliaFormatter.toml #398

Closed
svilupp opened this issue Mar 12, 2023 · 0 comments · Fixed by #464
Closed

Introduce automatic code formatting with JuliaFormatter.toml #398

svilupp opened this issue Mar 12, 2023 · 0 comments · Fixed by #464

Comments

@svilupp
Copy link
Contributor

svilupp commented Mar 12, 2023

Would it be possible to pick a code style for automatic formatting with JuliaFormatter and codify this choice in a .JuliaFormatter.toml file?

I believe it would improve the consistency of the code style, but, most importantly, make it easier for contributors to adhere to the same style (and, hence, improve their quality and cadence).

For example, whenever I want to contribute / experiment with changes, I have to disable my auto-formatting (as there is no .JuliaFormatter.toml file) and make all formatting changes manually. I'm certain people will often miss some style issues, so it will lead to repeated PR edits just to align the style.

@baumgold baumgold mentioned this issue Jun 12, 2023
baumgold added a commit that referenced this issue Jun 14, 2023
I used the default JuliaFormatter options, but we can customize them if
we want to with a `.JuliaFormatter.toml` file. Details available here:

https://domluna.github.io/JuliaFormatter.jl

Fixes #398.  CC: @svilupp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant