-
Notifications
You must be signed in to change notification settings - Fork 96
GH-110: Flight SQL JDBC related StringView components implementation #905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
|
@lidavidm I have drafted something; could you help me determine if I am on the right track? Currently, all the tests are being modified in-place, and I plan to refine them further. Do you think there are additional tests I should include? |
lidavidm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me.
| new FieldType( | ||
| true, | ||
| ArrowType.Utf8.INSTANCE, | ||
| ArrowType.Utf8View.INSTANCE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we add a new assertion instead of removing the existing one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
|
Thanks for your implementation! Our project is being blocked by this. What help I can provide so this pr can be merged soon? |
|
@lewiszlw It's ready for review now. |
|
I build jdbc driver package from your branch and tested it in our project, but got error |
|
could you share the stack? @lewiszlw |
Our stack is rust built server based on Datafusion query engine, and expose flight sql api. Our clients are Java stack. I used dbevaer software to verify your branch. |
|
@lewiszlw |
|
I sent a pr to your branch. I'm testing it. Note that I can only test binary view type. @ViggoC |
|
@lewiszlw Given that you have a real usage environment, it would be great if you are willing to make the fixes. |
What's Changed
Flight SQL JDBC related StringView components implementation.
Closes #110.