Skip to content

Conversation

@ViggoC
Copy link
Contributor

@ViggoC ViggoC commented Nov 5, 2025

What's Changed

Flight SQL JDBC related StringView components implementation.

Closes #110.

@github-actions

This comment has been minimized.

@ViggoC
Copy link
Contributor Author

ViggoC commented Nov 5, 2025

@lidavidm I have drafted something; could you help me determine if I am on the right track? Currently, all the tests are being modified in-place, and I plan to refine them further. Do you think there are additional tests I should include?

@lidavidm lidavidm added the enhancement PRs that add or improve features. label Nov 10, 2025
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

new FieldType(
true,
ArrowType.Utf8.INSTANCE,
ArrowType.Utf8View.INSTANCE,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we add a new assertion instead of removing the existing one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@lewiszlw
Copy link
Member

Thanks for your implementation! Our project is being blocked by this. What help I can provide so this pr can be merged soon?

@ViggoC ViggoC marked this pull request as ready for review November 19, 2025 13:32
@github-actions github-actions bot added this to the 18.4.0 milestone Nov 19, 2025
@ViggoC
Copy link
Contributor Author

ViggoC commented Nov 19, 2025

@lewiszlw It's ready for review now.

@lewiszlw
Copy link
Member

I build jdbc driver package from your branch and tested it in our project, but got error Unsupported vector type: org.apache.arrow.driver.jdbc.shaded.org.apache.arrow.vector.ViewVarBinaryVector. @ViggoC

@ViggoC
Copy link
Contributor Author

ViggoC commented Nov 20, 2025

could you share the stack? @lewiszlw

@lewiszlw
Copy link
Member

could you share the stack? @lewiszlw

Our stack is rust built server based on Datafusion query engine, and expose flight sql api. Our clients are Java stack.

I used dbevaer software to verify your branch.

@ViggoC
Copy link
Contributor Author

ViggoC commented Nov 21, 2025

@lewiszlw
From your error message, I can confirm it's because ArrowFlightJdbcAccessor doesn't support StringView. But I'm not familiar with Flight JDBC, so I'm not sure how much work still need to fully support StringView. I need to first build an end-to-end test to confirm which parts are not yet supported.

@lewiszlw
Copy link
Member

I sent a pr to your branch. I'm testing it. Note that I can only test binary view type. @ViggoC

@ViggoC
Copy link
Contributor Author

ViggoC commented Nov 21, 2025

@lewiszlw Given that you have a real usage environment, it would be great if you are willing to make the fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PRs that add or improve features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Java] Flight SQL JDBC related StringView components implementation

3 participants