Skip to content

GH-737: [FlightSQL] Allow returning column remarks in FlightSQL's CommandGetTables #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2025
Merged

GH-737: [FlightSQL] Allow returning column remarks in FlightSQL's CommandGetTables #727

merged 2 commits into from
May 3, 2025

Conversation

@mateuszrzeszutek
Copy link
Contributor

@mateuszrzeszutek mateuszrzeszutek commented Apr 24, 2025 •
edited
Loading

Resolves #737

What's Changed

This is a draft implementation of apache/arrow#46110 for Java

@github-actions

This comment has been minimized.

Sign in to view
@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Apr 24, 2025
Merged
@lidavidm lidavidm added the enhancement PRs that add or improve features. label Apr 24, 2025
@mateuszrzeszutek mateuszrzeszutek changed the title GH-46087: [FlightSQL] Allow returning column remarks in FlightSQL's CommandGetTables [FlightSQL] Allow returning column remarks in FlightSQL's CommandGetTables May 2, 2025
@mateuszrzeszutek mateuszrzeszutek marked this pull request as ready for review May 2, 2025 08:50
@mateuszrzeszutek mateuszrzeszutek changed the title [FlightSQL] Allow returning column remarks in FlightSQL's CommandGetTables GH-727 [FlightSQL] Allow returning column remarks in FlightSQL's CommandGetTables May 2, 2025
@mateuszrzeszutek mateuszrzeszutek changed the title GH-727 [FlightSQL] Allow returning column remarks in FlightSQL's CommandGetTables GH-737: [FlightSQL] Allow returning column remarks in FlightSQL's CommandGetTables May 2, 2025
@github-actions github-actions bot added this to the 18.3.0 milestone May 2, 2025
@mateuszrzeszutek
Copy link
Contributor Author

mateuszrzeszutek commented May 2, 2025

Hey @jbonofre @lidavidm looks like the PR format check is failing:

PR has milestone: 18.3.0
Linked issue: 737
failed to update https://github.com/apache/arrow-java/issues/737: GraphQL: Resource not accessible by integration (updateIssue)
failed to update 1 issue

Anything I can do to fix that?

@lidavidm
Copy link
Member

lidavidm commented May 2, 2025

Don't worry about that, it's because I'm waiting on Apache to clarify whether I'm allowed to use GH_TOKEN from a script action...

@lidavidm lidavidm merged commit 8314c19 into apache:main May 3, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbonofre jbonofre jbonofre approved these changes

@lidavidm lidavidm lidavidm approved these changes

@laurentgo laurentgo Awaiting requested review from laurentgo laurentgo is a code owner

@wgtmac wgtmac Awaiting requested review from wgtmac wgtmac is a code owner

Assignees

No one assigned

Labels

enhancement PRs that add or improve features.

Projects

None yet

Milestone

18.3.0

Development

Successfully merging this pull request may close these issues.

[FlightSQL] Allow returning column remarks in FlightSQL's CommandGetTables

3 participants

@mateuszrzeszutek @lidavidm @jbonofre