-
Notifications
You must be signed in to change notification settings - Fork 95
GH-499: Require PR labels for changelog #594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks good. Maybe we should also update the GitHub PR Template to "strongly" emphasize on issue ? |
|
Will do. It looks like you can't have selectors in pull request templates like you can in issues, but looks like we could add a set of checkboxes and have the action populate the labels based on that instead (or something similar) |
|
Yes. It's what I have in mind. |
|
I've updated this with an action that checks the title, linked issue, and labels. Demo here: lidavidm#6 If missing a label it will make a comment, when the label is added it will hide the comment. |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Let's try this!
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
GH-499is actually linked to issue#499by poking the GitHub API.Closes #499.