Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Jan 10, 2025

No description provided.

@lidavidm
Copy link
Member

I asked about reverting since, if we do actually run the RC release job nightly, and it uploads to a GitHub release, we either need to put -SNAPSHOT back in the version or we need to make sure the GitHub release is clearly marked as a draft/prerelease version.

@kou
Copy link
Member Author

kou commented Jan 10, 2025

if we do actually run the RC release job nightly, and it uploads to a GitHub release, we either need to put -SNAPSHOT back in the version or we need to make sure the GitHub release is clearly marked as a draft/prerelease version.

Ah, I understand your concern!
The nightly RC workflow doesn't uploads artifacts to a GitHub release.
Because the upload job is used only for tag push: https://github.com/apache/arrow-java/pull/496/files#diff-2ff8a59693d8d05dd67560f01c2a49d9e05f4b1ccefeb91f8486744532214e44R113

@kou
Copy link
Member Author

kou commented Jan 10, 2025

Anyway, I merge this for testing.

@kou kou merged commit de80cef into apache:main Jan 10, 2025
15 of 16 checks passed
@kou kou deleted the bump-version-18.2.0 branch January 10, 2025 05:47
@lidavidm lidavidm added this to the 18.2.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants