GH-48: Implement VectorAppender for BaseVariableWidthViewVector #454
+218
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViggoC
force-pushed
the
viggo/string-view-appender
branch
from
bfa1bcf to
5470deb
Compare
lidavidm
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Does this test the case of multiple data buffers?
There was a problem hiding this comment.
You mean ViewVarCharVector.dataBuffers.size() > 1. I'm afraid not. I'll check it, and add a case if it's not covered.
ViggoC
commented
Jan 19, 2025
| VectorAppender appender = new VectorAppender(target); | ||
| delta.accept(appender, null); | ||
|
|
||
| assertEquals(2, target.getDataBuffers().size()); |
There was a problem hiding this comment.
@lidavidm ViewVarCharVector.dataBuffers.size() > 1 is already covered in this test case.
There was a problem hiding this comment.
But what about the cases where target and delta have more than one data buffer before appending?
There was a problem hiding this comment.
It's covered in e918540.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48.