Skip to content

fix(parquet/variant): fix basic stringify #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeroshade merged 1 commit into from
Jan 7, 2026
Merged

fix(parquet/variant): fix basic stringify #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parquet/variant/variant.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ func (v Value) Value() any {
case BasicArray:
valueHdr := (v.value[0] >> basicTypeBits)
fieldOffsetSz := (valueHdr & 0b11) + 1
isLarge := (valueHdr & 0b1) == 1
isLarge := ((valueHdr >> 2) & 0b1) == 1

var (
sz int
Expand Down
25 changes: 25 additions & 0 deletions parquet/variant/variant_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,3 +783,28 @@ func TestValueCloneConsistency(t *testing.T) {
assert.Equal(t, variant.String, cloned.Type())
assert.Equal(t, "test", cloned.Value())
}

// test fix from github.com/apache/arrow-go/issues/623
func TestVariantJSONRoundTrip(t *testing.T) {
jsonBytes := []byte(`{
"object_array": [
{
"a_field_name_1": "some value AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA",
"a_field_name_2": "some value AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA",
"a_field_name_3": "some value",
"a_field_name_4": "some value",
"a_field_name_5": "some value",
"a_field_name_6": "some value",
"a_field_name_7": "some value",
"a_field_name_8": "some value",
"a_field_name_9": "some value",
"a_field_name_10": "some value"
}
]
}`)
variantFromJSON, err := variant.ParseJSONBytes(jsonBytes, false)
if err != nil {
panic(err)
}
assert.JSONEq(t, string(jsonBytes), variantFromJSON.String())
}