Generate variant tests in GO language #476
Closed
+399
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is to generate the test files by reading the files from apache/parquet-testing#91 and writing out the same files through GO implementation. The files are generated in apache/parquet-testing#93. A few invalid cases are not generated from GO.
Then I tested out using Parquet-Java against those test files.
VARIANT(1)instead ofVARIANT(0)since the variant spec version should be 1.TIME(MICROS,false)per spec, notTIME(MICROS,true).What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?