-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python/adbc_driver_manager: test_lowlevel.py::test_pycapsule failed with PyArrow >= 17 #2111
Labels
Type: enhancement
New feature or request
Milestone
Comments
We can relax the pattern |
lidavidm
changed the title
pytyon/adbc_driver_manager: test_lowlevel.py::test_pycapsule failed with PyArrow >= 17
python/adbc_driver_manager: test_lowlevel.py::test_pycapsule failed with PyArrow >= 17
Sep 1, 2024
lidavidm
added a commit
to lidavidm/arrow-adbc
that referenced
this issue
Sep 2, 2024
Ah, I had pinned pyarrow...let's try unpinning things |
lidavidm
added a commit
to lidavidm/arrow-adbc
that referenced
this issue
Sep 2, 2024
We should be better about testing different versions: #2113 |
lidavidm
added a commit
to lidavidm/arrow-adbc
that referenced
this issue
Sep 2, 2024
lidavidm
added a commit
to lidavidm/arrow-adbc
that referenced
this issue
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What feature or improvement would you like to see?
arrow-adbc/python/adbc_driver_manager/tests/test_lowlevel.py
Line 457 in cda3468
uses
... ArrowArrayStream
as the expected error message but https://github.com/apache/arrow/pull/40807/files#diff-8897de719613dfdec93c98eca5567d157a0848802cf8554959ca2ebdde3c6839L2329-R2448 (Hmm, we need to "Load diff" ofbridge.cc
explicitly) changed the error message. So the test works with PyArrow < 17 but doesn't work with PyArrow >= 17.Can we relax the error message pattern or something to support both of old PyArrow and new PyArrow?
Or we may be able to drop support for old PyArrow in our test.
The text was updated successfully, but these errors were encountered: