Fix timeout integer overflow #62
Open
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix integer overflow in apr_wait_for_io_or_timeout by performing the microseconds to milliseconds conversion before assigning to 32-bit timeout.
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Oct 17, 2025
…econds to an INT32 timeout in milliseconds. PR: 69542 Obtained from: #62 Submitted by: [Alejandro Perez <[email protected]>] Reviewed by: rpluem git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1929188 13f79535-47bb-0310-9956-ffa450edef68
|
Committed to trunk as 52bb09e / r1929188. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix integer overflow in apr_wait_for_io_or_timeout by performing the microseconds to milliseconds conversion before assigning to 32-bit timeout.
The timeout overflow occurs in APR's waitio.c when converting microseconds to milliseconds for poll(), where any timeout above 28 minutes and 25 seconds fails because the 32-bit integer overflows.
The proposed fix handles the conversion before assigning to the 32-bit integer, allowing timeouts up to 24.85 days to work correctly. Since poll() itself uses a 32-bit timeout parameter and practical timeouts rarely exceed days (max around 25 days), this fix handles all real-world use cases.
I reported this bug in https://bz.apache.org/bugzilla/show_bug.cgi?id=69542