test: cover grpc-transcode empty array responses #12649
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
5 tasks
Baoyuantop
approved these changes
Nov 13, 2025
Contributor
|
Hi @bytelazy, could you merge the latest main branch? |
Author
sure~ |
Member
|
pls merge the fix the ci case: |
nic-6443
reviewed
Nov 24, 2025
| if type(v) == "table" then | ||
| local sub_names = fetch_proto_array_names(v) | ||
| for sub_name,_ in pairs(sub_names) do | ||
| names[sub_name] = 1 |
Member
There was a problem hiding this comment.
Suggested change
| names[sub_name] = 1 | |
| names[sub_name] = true |
nic-6443
reviewed
Nov 24, 2025
| local PROTOBUF_REPEATED_LABEL = 3 | ||
| local repeated_label = PROTOBUF_REPEATED_LABEL | ||
|
|
||
| local function fetch_proto_array_names(proto_obj) |
Member
There was a problem hiding this comment.
This function does not take into account the possibility of duplicate names in nested fields, for example:
message Company {
repeated string name = 1;
}
message HelloRequest {
string name = 1;
Company company = 2;
}
AlinsRan
reviewed
Nov 24, 2025
|
|
||
| local function fetch_proto_array_names(proto_obj) | ||
| local names = {} | ||
| if type(proto_obj) == "table" then |
Contributor
There was a problem hiding this comment.
Suggested change
| if type(proto_obj) == "table" then | |
| if type(proto_obj) ~= "table" then | |
| return | |
| end |
AlinsRan
reviewed
Nov 24, 2025
| return err_msg | ||
| end | ||
|
|
||
| local array_names = fetch_proto_array_names(proto) |
Contributor
There was a problem hiding this comment.
We can cache it without having to reprocess it every time a request is made.
Baoyuantop
added
the
wait for update
Contributor
|
Hi @bytelazy, please check these comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the grpc-transcode plugin, when a repeated field in the gRPC response is empty, it is incorrectly encoded as an empty JSON object ({}) instead of an empty JSON array ([]). This behavior does not comply with the gRPC-JSON transcoding specification and can cause type-related errors on the client-side, which expects an array.
Fixes #11440
Checklist
Changes or the new features added to this PR
The main changes are in the response.lua file to correctly handle the serialization of repeated fields.
Identify repeated fields: A new function fetch_proto_array_names has been added. It recursively traverses the loaded Protobuf schema definition to identify and collect the names of all fields marked as repeated.
Ensure correct JSON array serialization:
A new function set_default_array has been introduced. After the gRPC response is decoded into a Lua table, this function traverses the table.
For any field that was identified as repeated, it sets a specific metatable (core.json.array_mt).
This metatable forces the core.json.encode function to serialize the corresponding Lua table as a JSON array ([]), even when it is empty.
This logic is applied just before the decoded response is encoded into the final JSON output, ensuring the structure is correct.