Skip to content

docs: improve prometheus plugin docs #11874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guoqqqi merged 7 commits into from
Jan 3, 2025
Merged

docs: improve prometheus plugin docs #11874

guoqqqi merged 7 commits into from
Jan 3, 2025

Conversation

@Yilialinn
Copy link
Contributor

@Yilialinn Yilialinn commented Dec 30, 2024 •
edited
Loading

Description

Improve prometheus plugin docs and add Chinese doc.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. doc Documentation things labels Dec 30, 2024
Yilialinn
Yilialinn commented Dec 30, 2024
View reviewed changes
kayx23
kayx23 reviewed Dec 31, 2024
View reviewed changes
kayx23
kayx23 reviewed Jan 1, 2025
View reviewed changes
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jan 2, 2025
kayx23
kayx23 reviewed Jan 2, 2025
View reviewed changes
kayx23
kayx23 reviewed Jan 2, 2025
View reviewed changes
@kayx23
Copy link
Member

kayx23 commented Jan 2, 2025

Please fix for the above comments and lint errors. Other changes LGTM.

moonming
moonming previously approved these changes Jan 2, 2025
View reviewed changes
@guoqqqi guoqqqi merged commit 284632f into apache:master Jan 3, 2025
7 checks passed
@Yilialinn Yilialinn deleted the patch-2 branch January 3, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moonming moonming moonming approved these changes

@kayx23 kayx23 kayx23 approved these changes

@guoqqqi guoqqqi guoqqqi approved these changes

Assignees

No one assigned

Labels

doc Documentation things size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yilialinn @kayx23 @moonming @guoqqqi