Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new keepalive_pool field to ApisixUpstream CR #2310

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

slayer321
Copy link

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Fixes #1883
adds the new field keepalive_pool for ApisixUpstream CR

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@slayer321
Copy link
Author

slayer321 commented Oct 16, 2024

I have made all the required changes but I was not able to test it as I'm still stuck on the CRD's generation. One of the ways I tried doing it below

controller-gen crd paths=./pkg/kube/apisix/apis/... output:crd:dir=./samples/deploy/crd/v1

It is generating a whole new files for me. Please do let me know how can I generated the CRD's for this project.

@slayer321 slayer321 marked this pull request as ready for review October 16, 2024 17:19
Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

help request: How to define keepalive through ApisixUpstream_ The idle of the pool_ Timeout
1 participant