feat: support GatewayClass, refactor gateway modules #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ling Samuel <[email protected]>
Signed-off-by: Ling Samuel <[email protected]>
Signed-off-by: Ling Samuel <[email protected]>
Signed-off-by: Ling Samuel <[email protected]>
Signed-off-by: Ling Samuel <[email protected]>
|
please fix CI errors. |
Signed-off-by: Ling Samuel <[email protected]>
Signed-off-by: Ling Samuel <[email protected]>
Signed-off-by: Ling Samuel <[email protected]>
Signed-off-by: Ling Samuel <[email protected]>
Signed-off-by: Ling Samuel <[email protected]>
Signed-off-by: Ling Samuel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
==========================================
+ Coverage 30.83% 32.08% +1.25%
==========================================
Files 77 78 +1
Lines 9140 8795 -345
==========================================
+ Hits 2818 2822 +4
+ Misses 6019 5666 -353
- Partials 303 307 +4
Continue to review full report at Codecov.
|
tao12345666333
approved these changes
Jun 15, 2022
Comment on lines
+32
to
+33
| // FIXME: Controller should be the Core Part, | ||
| // Provider should act as "EventHandler", register there functions to Controller |
There was a problem hiding this comment.
Will it be implemented in a follow-up PR?
There was a problem hiding this comment.
Yes. The core concept here is that the providers shouldn't interact directly with the controller's field, for example add event handlers directly to the informers.
Co-authored-by: Jintao Zhang <[email protected]>
gxthrj
approved these changes
Jun 16, 2022
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ling Samuel [email protected]
Type of change: