Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): allowing cors to dynamically adapt to the BE rules #1994

Merged
merged 5 commits into from
Aug 20, 2021

Conversation

wmdmomo
Copy link
Contributor

@wmdmomo wmdmomo commented Jul 24, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?
The PR will change the plugin under plugin/UI (Cors), allowing Cors to dynamically adapt to the back-end json rules.

Related issues

fix/resolve #1588

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Jul 24, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: fea1e86

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/61110b05188f0b0007e25400

😎 Browse the preview: https://deploy-preview-1994--apisix-dashboard.netlify.app/

@wmdmomo wmdmomo changed the title Feature cors 20210722 feat(plugin): fix UI Cors Jul 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #1994 (c568b0e) into master (0b5196f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c568b0e differs from pull request most recent head 5a0a880. Consider uploading reports for the commit 5a0a880 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1994   +/-   ##
=======================================
  Coverage   64.01%   64.01%           
=======================================
  Files         122      122           
  Lines        3154     3160    +6     
  Branches      753      754    +1     
=======================================
+ Hits         2019     2023    +4     
- Misses       1135     1137    +2     
Flag Coverage Δ
frontend-e2e-test 64.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/PluginDetail.tsx 65.82% <100.00%> (+0.21%) ⬆️
web/src/components/Plugin/UI/cors.tsx 89.28% <100.00%> (+2.32%) ⬆️
web/src/components/Plugin/UI/plugin.tsx 82.60% <100.00%> (ø)
web/src/helpers.tsx 68.85% <0.00%> (-3.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5196f...5a0a880. Read the comment docs.

@LiteSun LiteSun changed the title feat(plugin): fix UI Cors feat(plugin): allowing cors to dynamically adapt to the BE rules Jul 26, 2021
@liuxiran liuxiran merged commit 2e8c2de into apache:master Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize front-end validation of fields
7 participants