-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve Route module #1715
Conversation
As for Testcases, failed due to the |
This PR mainly contains changes about i18n key & added some fields description, no logic changes. |
for other fields, I will send a new PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for CI failure. Please fix it.
Codecov Report
@@ Coverage Diff @@
## master #1715 +/- ##
==========================================
- Coverage 72.04% 71.67% -0.37%
==========================================
Files 132 47 -85
Lines 5687 3128 -2559
Branches 660 0 -660
==========================================
- Hits 4097 2242 -1855
+ Misses 1346 643 -703
+ Partials 244 243 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the code, it would be better to fix ci errors before approved, thanks
Sure, because we have many text changes, need some time to fix them haha |
ci failed |
yes, I'm fixing those CIs. |
debugging, 3 tests left. |
chore: improve Route module (apache#1715)
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Related issues
None
Checklist:
Screenshot