Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove the etcd dependency in the service unit test #1169

Merged
merged 7 commits into from
Feb 5, 2021

Conversation

starsz
Copy link
Contributor

@starsz starsz commented Dec 31, 2020

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • [] Bugfix

  • New feature provided

  • Improve performance

  • Related issues

#1161

New feature or improvement

  • Describe the details and related test reports.

Remove the etcd dependency in the service unit test

@codecov-io
Copy link

codecov-io commented Dec 31, 2020

Codecov Report

Merging #1169 (f8239e2) into master (9824b5f) will decrease coverage by 10.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1169       +/-   ##
===========================================
- Coverage   67.08%   56.93%   -10.15%     
===========================================
  Files          46       46               
  Lines        2947     2947               
===========================================
- Hits         1977     1678      -299     
- Misses        731     1004      +273     
- Partials      239      265       +26     
Impacted Files Coverage Δ
api/internal/handler/plugin/plugin.go 16.66% <0.00%> (-70.00%) ⬇️
api/internal/core/store/query.go 45.23% <0.00%> (-52.39%) ⬇️
api/internal/core/store/selector.go 35.18% <0.00%> (-51.86%) ⬇️
api/internal/core/store/validate_mock.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/filter/authentication.go 44.11% <0.00%> (-32.36%) ⬇️
api/internal/core/store/store.go 56.96% <0.00%> (-29.70%) ⬇️
api/internal/handler/global_rule/global_rule.go 64.51% <0.00%> (-19.36%) ⬇️
api/internal/handler/consumer/consumer.go 74.46% <0.00%> (-17.03%) ⬇️
api/internal/handler/ssl/ssl.go 33.33% <0.00%> (-14.82%) ⬇️
api/internal/utils/json_patch.go 44.82% <0.00%> (-13.80%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9824b5f...f8239e2. Read the comment docs.

@starsz starsz marked this pull request as ready for review January 4, 2021 06:10
@starsz starsz marked this pull request as draft January 6, 2021 02:32
@starsz starsz marked this pull request as ready for review January 17, 2021 07:03
@juzhiyuan
Copy link
Member

@starsz you need to request members to review.

@starsz starsz requested a review from imjoey February 4, 2021 06:00
@juzhiyuan
Copy link
Member

waiting for #1426

@juzhiyuan
Copy link
Member

@starsz You may need to request reviews from others first.

@juzhiyuan
Copy link
Member

may sync the latest codes to fix E2E failed.

Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Nice PR and will make writing backend unit test more convenient. Thanks @starsz .

@starsz starsz merged commit 661e48f into apache:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants