-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove the etcd dependency in the service unit test #1169
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1169 +/- ##
===========================================
- Coverage 67.08% 56.93% -10.15%
===========================================
Files 46 46
Lines 2947 2947
===========================================
- Hits 1977 1678 -299
- Misses 731 1004 +273
- Partials 239 265 +26
Continue to review full report at Codecov.
|
@starsz you need to request members to review. |
waiting for #1426 |
@starsz You may need to request reviews from others first. |
may sync the latest codes to fix E2E failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Nice PR and will make writing backend unit test more convenient. Thanks @starsz .
Please answer these questions before submitting a pull request
Why submit this pull request?
[] Bugfix
New feature provided
Improve performance
Related issues
#1161
New feature or improvement
Remove the etcd dependency in the service unit test