Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the optional dependencies #138

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

twogee
Copy link
Contributor

@twogee twogee commented Oct 4, 2020

No description provided.

@twogee twogee force-pushed the fresh-dependencies branch from 9ee75d0 to 3a0c306 Compare December 9, 2020 20:58
@twogee twogee force-pushed the fresh-dependencies branch from 3a0c306 to 9f03aa6 Compare January 30, 2021 15:38
@twogee twogee force-pushed the fresh-dependencies branch 2 times, most recently from de1d02f to 1ee6231 Compare March 6, 2021 19:19
@twogee twogee force-pushed the fresh-dependencies branch from 1ee6231 to 6de7231 Compare March 14, 2021 22:04
@twogee twogee force-pushed the fresh-dependencies branch from 6de7231 to 3c9add2 Compare June 8, 2021 06:49
@twogee twogee force-pushed the fresh-dependencies branch from 3c9add2 to 7d1cd33 Compare July 18, 2021 13:20
@bodewig
Copy link
Member

bodewig commented Sep 26, 2021

@twogee the switch to jakarta.mail is not backwards compatible. I don't think we can do it that way at all. Rather we'll need to introduce a new type of Mailer and an additional jar with different dependencies, I'm afraid.

@twogee twogee force-pushed the fresh-dependencies branch from 7d1cd33 to 7b26711 Compare October 2, 2021 04:40
@bodewig
Copy link
Member

bodewig commented Oct 2, 2021

Thank you @twogee - do you think you could split the Jakarta Mailer support changes from the other changes?

The changes to ClasspathUtils seem to be completely unrelated to either and the chunk that removes string concatenation is completely unnecessary anyway.

@twogee
Copy link
Contributor Author

twogee commented Oct 2, 2021

Thanks, @bodewig, and sorry about missing the extraneous changes.
I will open a new PR for changes re Jakarta Mail specifically.
The change to ClasspathUtils is related to an attempt to avoid nested try in EmailTask#getMailerImplementation().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants