Skip to content

[AMORO-3943] Shade all third party classes for spark runtime #3942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoujinsong merged 2 commits into from
Dec 29, 2025
Merged

[AMORO-3943] Shade all third party classes for spark runtime #3942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dc4361
relocate
turboFei Nov 15, 2025
c85017f
filter
turboFei Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions amoro-format-mixed/amoro-mixed-spark/v3.3/amoro-mixed-spark-runtime-3.3/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,23 @@
<exclude>META-INF/services/org.apache.spark.sql.sources.DataSourceRegister</exclude>
</excludes>
</filter>
<filter>
Copy link
Contributor

@zhoujinsong zhoujinsong Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we manege the filter in the plugin manager like :https://github.com/apache/amoro/blob/master/pom.xml#L1560

Copy link
Member Author

@turboFei turboFei Dec 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would not work once we override the configuration in sub module

<artifact>*:*</artifact>
<excludes>
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
<exclude>**/log4j.properties</exclude>
<exclude>META-INF/DEPENDENCIES</exclude>
<exclude>META-INF/*LICENSE*</exclude>
<exclude>META-INF/MANIFEST.MF</exclude>
<exclude>META-INF/*NOTICE*</exclude>
<exclude>META-INF/**/module-info.class</exclude>
<exclude>LICENSE.txt</exclude>
<exclude>NOTICE.txt</exclude>
<exclude>mozilla/*.txt</exclude>
</excludes>
</filter>
</filters>
<relocations>
<!-- relocation amoro spark packages -->
Expand All @@ -134,6 +151,11 @@
<pattern>org.apache.orc</pattern>
<shadedPattern>org.apache.amoro.shade.org.apache.orc</shadedPattern>
</relocation>
<!-- classes in orc-core -->
<relocation>
<pattern>org.threeten</pattern>
<shadedPattern>org.apache.amoro.shade.org.threeten</shadedPattern>
</relocation>
<relocation>
<pattern>org.apache.avro</pattern>
<shadedPattern>org.apache.amoro.shade.org.apache.avro</shadedPattern>
Expand Down Expand Up @@ -186,6 +208,18 @@
<pattern>org.apache.commons.lang3</pattern>
<shadedPattern>org.apache.amoro.shade.org.apache.commons.lang3</shadedPattern>
</relocation>
<relocation>
<pattern>org.apache.commons.io</pattern>
<shadedPattern>org.apache.amoro.shade.org.apache.commons.io</shadedPattern>
</relocation>
<relocation>
<pattern>org.apache.thrift</pattern>
<shadedPattern>org.apache.amoro.shade.org.apache.thrift</shadedPattern>
</relocation>
<relocation>
<pattern>com.github.benmanes</pattern>
<shadedPattern>org.apache.amoro.shade.com.github.benmanes</shadedPattern>
</relocation>

<!-- relocation iceberg -->
<relocation>
Expand Down
34 changes: 34 additions & 0 deletions amoro-format-mixed/amoro-mixed-spark/v3.5/amoro-mixed-spark-runtime-3.5/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,23 @@
<exclude>META-INF/services/org.apache.spark.sql.sources.DataSourceRegister</exclude>
</excludes>
</filter>
<filter>
<artifact>*:*</artifact>
<excludes>
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
<exclude>**/log4j.properties</exclude>
<exclude>META-INF/DEPENDENCIES</exclude>
<exclude>META-INF/*LICENSE*</exclude>
<exclude>META-INF/MANIFEST.MF</exclude>
<exclude>META-INF/*NOTICE*</exclude>
<exclude>META-INF/**/module-info.class</exclude>
<exclude>LICENSE.txt</exclude>
<exclude>NOTICE.txt</exclude>
<exclude>mozilla/*.txt</exclude>
</excludes>
</filter>
</filters>
<relocations>
<!-- relocation amoro spark packages -->
Expand All @@ -133,6 +150,11 @@
<pattern>org.apache.orc</pattern>
<shadedPattern>org.apache.amoro.shade.org.apache.orc</shadedPattern>
</relocation>
<!-- classes in orc-core -->
<relocation>
<pattern>org.threeten</pattern>
<shadedPattern>org.apache.amoro.shade.org.threeten</shadedPattern>
</relocation>
<relocation>
<pattern>org.apache.avro</pattern>
<shadedPattern>org.apache.amoro.shade.org.apache.avro</shadedPattern>
Expand Down Expand Up @@ -185,6 +207,18 @@
<pattern>org.apache.commons.lang3</pattern>
<shadedPattern>org.apache.amoro.shade.org.apache.commons.lang3</shadedPattern>
</relocation>
<relocation>
<pattern>org.apache.commons.io</pattern>
<shadedPattern>org.apache.amoro.shade.org.apache.commons.io</shadedPattern>
</relocation>
<relocation>
<pattern>org.apache.thrift</pattern>
<shadedPattern>org.apache.amoro.shade.org.apache.thrift</shadedPattern>
</relocation>
<relocation>
<pattern>com.github.benmanes</pattern>
<shadedPattern>org.apache.amoro.shade.com.github.benmanes</shadedPattern>
</relocation>

<!-- relocation iceberg -->
<relocation>
Expand Down