Skip to content

Conversation

@xxubai
Copy link
Contributor

@xxubai xxubai commented Apr 2, 2024

Why are the changes needed?

Close #2710

Brief change log

  • To improve the efficiency of file deletion and avoid rate limiting due to a large number of requests, especially for S3

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@github-actions github-actions bot added module:core Core module module:ams-server Ams server module labels Apr 2, 2024
Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contributions.

@baiyangtx baiyangtx merged commit ed882e1 into apache:master Apr 11, 2024
@xxubai xxubai deleted the bulk-ops branch April 11, 2024 11:56
xxubai added a commit to xxubai/amoro that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module module:core Core module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: The time overhead for file deletion during maintenance is significant

2 participants