Skip to content

Conversation

@mradha25
Copy link
Contributor

mpack API change - #486 , Fix the remaining mpack-related unit tests?

[ERROR] MpackResourceProviderTest.testGetResourcesMpacks:122 expected:<2> but was:<0>
[ERROR] MpackResourceProviderTest.testGetResourcesMpackId:189 » NoSuchResource
(Note these occur after – before that change, all 3 test methods throw NullPointer instead.)

How was this patch tested?

Run Mpack Unit Tests

Please review Ambari Contributing Guide before opening a pull request.

ResourceDefinition def = new MpackResourceDefinition();
assertEquals("mpack", def.getSingularName());
assertEquals("mpacks", def.getPluralName());

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be unnecessary.

@mradha25 mradha25 merged commit 48b9007 into apache:branch-feature-AMBARI-14714 Apr 4, 2018
@mradha25 mradha25 deleted the AMBARI-22904 branch April 4, 2018 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants