Skip to content

Conversation

@kinow
Copy link
Member

@kinow kinow commented Aug 21, 2017

Fixing minor typo and extra spaces, but also re-working processIdentity's Javadoc. I found it a bit weird, but not sure if my choice of words is any better - not a native speaker :-)

Feel free to update the PR, or suggest another text and I will update the PR.

Thanks!
Bruno

Fixing minor typo and extra spaces, but also re-working `processIdentity`'s Javadoc. I found it a bit weird, but not sure if my choice of words is any better - not a native speaker :-)

Feel free to update the PR, or suggest another text and I will update the PR.

Thanks!
Bruno
@adoroszlai adoroszlai requested a review from rlevas January 12, 2018 19:52
@Jetly-Jaimin
Copy link
Contributor

@kinow can you please create Apache Ambari Jira for this PR. Each PR should be associated with corresponding Apache Ambari jira ?

@asfgit
Copy link

asfgit commented Jan 13, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/93/
Test FAILed.
Test FAILured.

@kinow
Copy link
Member Author

kinow commented Jan 13, 2018

Sure @Jetly-Jaimin, will create a ticket once I'm using my other notebook at $work during week. The other ticket was merged with not JIRA... so even trivial typos need JIRA's?

@adoroszlai
Copy link
Contributor

The How to Contribute guide says PRs can be linked to a related existing JIRA if the change is minor. (Although I'm not sure I see the value of even that for fixing typos.)

I think you can link to AMBARI-8454, which introduced the file being changed in this PR. Or to one of several JIRAs for typos, eg. AMBARI-18702.

@adoroszlai adoroszlai merged commit ef1b776 into apache:trunk Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants