Skip to content

Conversation

@smolnar82
Copy link
Contributor

What changes were proposed in this pull request?

There was a unit test failure due to a typo; fixed that issue

How was this patch tested?

Running the uni tests in ambari-client/groovy-client:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.ambari.groovy.client.AmbariHostsTest
[INFO] Running org.apache.ambari.groovy.client.AmbariClustersTest
[INFO] Running org.apache.ambari.groovy.client.AmbariBlueprintsTest
[INFO] Running org.apache.ambari.groovy.client.AmbariRecommendTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.256 s - in org.apache.ambari.groovy.client.AmbariClustersTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.282 s - in org.apache.ambari.groovy.client.AmbariHostsTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.334 s - in org.apache.ambari.groovy.client.AmbariRecommendTest
[INFO] Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.547 s - in org.apache.ambari.groovy.client.AmbariBlueprintsTest
[INFO] Running org.apache.ambari.groovy.client.AmbariServiceConfigurationTest
[INFO] Running org.apache.ambari.groovy.client.AmbariServicesTest
[INFO] Running org.apache.ambari.groovy.client.AmbariTasksTest
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.043 s - in org.apache.ambari.groovy.client.AmbariServicesTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.093 s - in org.apache.ambari.groovy.client.AmbariServiceConfigurationTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.068 s - in org.apache.ambari.groovy.client.AmbariTasksTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 41, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- apache-rat-plugin:0.12:check (default) @ groovy-client ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 61 implicit excludes (use -debug for more details).
[INFO] Exclude: **/*.iml
[INFO] Exclude: src/main/resources/blueprints/**
[INFO] Exclude: src/test/resources/**
[INFO] 16 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 16 licenses.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 7.621 s
[INFO] Finished at: 2018-03-05T08:36:20+01:00
[INFO] Final Memory: 18M/321M
[INFO] ------------------------------------------------------------------------

@smolnar82
Copy link
Contributor Author

@zeroflag @adoroszlai Could you please remove and merge this PR (prevents other build(s) from being processed successfully). Thanks!

@smolnar82 smolnar82 changed the title AMBARI-23140. Fixed typo in unit test [AMBARI-23140] Fixed typo in unit test Mar 5, 2018
@asfgit
Copy link

asfgit commented Mar 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/955/
Test PASSed.

@adoroszlai
Copy link
Contributor

@smolnar82, the typo was there since 2694510 (almost 4 years). Unit tests in groovy-client are fine locally without this fix, as well as in Jenkins. The same typo is being fixed on trunk in #525 along with httpclient upgrade in groovy-client. Since #538 is also upgrading httpclient and encountering this unit test failure, it seems to me that the failure is due to these upgrades.

@smolnar82
Copy link
Contributor Author

@adoroszlai in my opinion the issue was there for almost 4 years but it was somehow masked; with the new upgrades it's been discovered and being fixed.
Regarding #525 : I asked @zeroflag whether he already committed his changes on trunk; be he has not yet done it and I wanted the fix to go out ASAP.

@smolnar82
Copy link
Contributor Author

@rlevas @dlysnichenko could any of you please also review this PR? Thanks!

@adoroszlai adoroszlai merged commit 4396e09 into apache:trunk Mar 5, 2018
@smolnar82 smolnar82 deleted the AMBARI-23140 branch March 5, 2018 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants