[AMBARI-23032] fix exceptions, export cluster settings and single mpack #431

benyoka · 2018-02-21T16:17:16Z

This is the initial implementation of the cluster blueprint export for multi-mpack Ambari.
Things that changed:

Fixed exceptions occuring due to the new cluster structure
Exports cluster settings. Global recovery options are exported under cluster-settings as opposed to previous recovery-settings
Export mpack instances (currently only can export a single mpack)

How was this patch tested?

tested manually
I updated the ClusterBlueprintRendererTest unit tests
unit test results: Tests run: 5027, Failures: 25, Errors: 20, Skipped: 37

…s (benyoka)

adoroszlai · 2018-02-21T22:27:57Z

...erver/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java

  private Stack parseStack(Resource clusterResource) throws InvalidTopologyTemplateException {
-    String[] stackTokens = String.valueOf(clusterResource.getPropertyValue(
-        ClusterResourceProvider.CLUSTER_VERSION_PROPERTY_ID)).split("-");
+    Splitter splitter = Splitter.on('-').limit(2);  // We are only interested to split on the first '-', e.g.


This logic is already implemented in StackId, which I think we should reuse.
(I'm already doing that in my work-in-progress change.)

adoroszlai · 2018-02-21T22:28:54Z

...erver/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java

 import org.apache.ambari.server.topology.HostGroupInfo;
-import org.apache.ambari.server.topology.InvalidTopologyTemplateException;
-import org.apache.ambari.server.topology.TopologyRequest;
+import org.apache.ambari.server.topology.InvalidTopologyTemplateException;import org.apache.ambari.server.topology.TopologyRequest;


Looks like a newline is lost here.

adoroszlai · 2018-02-21T22:38:09Z

...server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java

+      for (TreeNode<Resource> clusterSettingNode: settingsNode.getChildren()) {
+        Map<String, Object> nodeProperties = clusterSettingNode.getObject().getPropertiesMap().get("ClusterSettingInfo");
+        String key = Objects.toString(nodeProperties.get("cluster_setting_name"));
+        String value = Objects.toString(nodeProperties.get("cluster_setting_value"));


Should be reusing constants from ClusterSettingResourceProvider.

adoroszlai · 2018-02-21T22:39:40Z

...server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java

+    String serviceGroupType = Resource.Type.ServiceGroup.name();
+    if (resultTree.getChild(serviceGroupType) == null) {
+      resultTree.addChild(new HashSet<>(), serviceGroupType);
+    }


Can you please extract and reuse this logic?

asfgit · 2018-02-21T23:36:59Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/736/
Test FAILed.
Test FAILured.

adoroszlai · 2018-02-22T13:10:00Z

.../main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java

      doFilterPriorToExport(configuration);
    }
-  }
+    }


Seems to be accidental.

asfgit · 2018-02-22T14:10:09Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/748/
Test FAILed.
Test FAILured.

asfgit · 2018-02-22T15:25:04Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/749/
Test FAILed.
Test FAILured.

asfgit · 2018-02-22T18:02:10Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/752/
Test FAILed.
Test FAILured.

…nto AMBARI-23032-branch-feature-AMBARI-14714

asfgit · 2018-02-26T12:46:39Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/816/
Test FAILed.
Test FAILured.

asfgit · 2018-02-26T15:34:27Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/819/
Test FAILed.
Test FAILured.

rnettleton

The patch looks fine to me, just a few questions/clarifications.

The patch looks ok to merge.

rnettleton · 2018-02-28T22:27:02Z

...server/src/main/java/org/apache/ambari/server/controller/internal/MpackResourceProvider.java

-      e1.printStackTrace();
+    }
+    catch (ConnectException e) {
+      throw new SystemException("The Mpack Uri: " + mpackRequest.getMpackUri() + " is not valid. Please try again", e);


Wouldn't a ConnectException also sometimes occur for a valid URI that happens to not be reachable with the given connection?

Its not a big deal for now, but maybe we should consider changing the error message here to make the error cause a little clearer.

Agreed it could be improved. The reason why I made this change is that the original code was swallowing exceptions and I could only see an NPE thrown elsewhere and had to spend time debugging what was actually happening.

rnettleton · 2018-02-28T22:29:26Z

...server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java

-      blueprintResource.setProperty("Blueprints/stack_version", stackId.getStackVersion());
-    }
+    // TODO: mpacks should come from service groups once https://github.com/apache/ambari/pull/234 will be committed
+    Collection<Map<String, String>> mpackInstances = stackIds.stream().


Will this query work for clusters that have been created by the Ambari UI?

Yes, I am testing it with a cluster that has been created via UI.

…eature-AMBARI-14714

asfgit · 2018-03-01T08:07:30Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/888/
Test FAILed.
Test FAILured.

…#610) * [AMBARI-22764] NN HA wizard is broken due to recent commit for config compare * AMBARI-22767. Kerberos wizard. Advanced kerberos-env password properties should be visible only if the KDC type is 'Active Directory' (alexantonenko) * AMBARI-22766 ambari-server setup with internal database may not work on centos 7 (dgrinenko) * AMBARI-22768. Update Welcome page style (akovalenko) * AMBARI-22772. Log Search / Log Feeder - config symlink cannot be created if etc/ambari-logsearch* folders do not exist * AMBARI-22771. Ambari loads ambari.properties using ISO 8859-1 encoding (adoroszlai) * [AMBARI-22770] Bring jenkins job build script under version control (#98) [AMBARI-22770] Bring jenkins job build script under version control * AMBARI-22637. Fix misuses of os.path.dirname(path) in yarn.py * AMBARI-22771. Fix broken unit test * AMBARI-22668. Moving LDAP related properties to DB upon upgrade to 3.0.0 * AMBARI-22668: implemented changes requested by reviewers * AMBARI-22668: implemented changes requested by rlevas * AMBARI-22783 Login page lost Ambari branding. (atkach) * AMBARI-22779. Cannot scale cluster if Ambari Server restarted since blueprint cluster creation * AMBARI-22789. Fix Log Search / Log Feeder / Infra Manager start scripts * AMBARI-22787 - Add new Ambari Infra Manager component to Ambari infra stack * AMBARI-22793. Notification popover layout issues * AMBARI-22785: added force_tcp option to KRB5 configuration template so that customers can choose TCP over UDP when communicating with Kerberos * AMBARI-22796. Widget menu goes out of bounds (alexantonenko) * AMBARI-22667: fix commons-io version * AMBARI-22794 Opacity decreased and the shadow has been added to the sticky filter bar. * AMBARI-22726. Fix dependent tests in BlueprintImplTest (#133) * Merge remote-tracking branch 'upstream/trunk' into branch-feature-AMBARI-20859 * AMBARI-22577. Migrate user data for upgrade to improved user account management * AMBARI-22806.Unable to delete files from HDFS using Ambari File View when Ambari Views is accessed via Knox(Venkata Sairam) * AMBARI-22792. Refactor agent-side kerberos code (echekanskiy) * AMBARI-22807. Admin View: Add/Delete Group succeeds, but the group table does not refresh automatically. (alexantonenko) * AMBARI-22809. Tez shown in red in the left nav for no apparent reason (alexantonenko) * AMBARI-22796. Widget menu goes out of bounds. review (alexantonenko) * AMBARI-22792. Refactor agent-side kerberos code - import fix (echekanskiy) * AMBARI-22812. Fix checkstyle error in UpgradeCatalog300Test (#148) * [AMBARI-22725] Expose Conditional Elements For Tasks on Upgrade * AMBARI-22795 LogSearch Fixes for LogList Display. (Istvan Tobias via ababiichuk) AMBARI-22795 LogSearch Fixes for LogList Display. (Istvan Tobias via ababiichuk) * AMBARI-22808 Ambari-Web: Fix randomly failing unit tests * AMBARI-22788 Unsightly artifacts during Login. (atkach) * AMBARI-22697. Throw exception when keytab creation fails due to wrong configuration of key encryption types * [AMBARI-22798] Role authorization AMBARI.MANAGE_CONFIGURATION is not added to AMBARI.ADMINISTRATOR role during Ambari upgrade * AMBARI-22818. Log Feeder: refactor - create plugin api * [AMBARI-22820] Fix KerberosOperationHandlerTests due to changes from AMBARI-22697 * AMBARI-22805. Blueprints do not handle some failures properly * AMBARI-22716: zeppelin.livy.url is not getting updated after moving livy to a new host (prabhjyotsingh) * AMBARI-22698: Custom zeppelin interpreter properties are getting removed after moving zeppelin to a different host (prabhjyotsingh) * AMBARI-22696 Whitelist execute latency from Storm Ambari metrics * AMBARI-22759 [Hive Views 2.0] Deleting a Saved query is Buggy when Mutliple Queries exist in same Name * Fix compilation issues after trunk merge (mradhakrishnan) * Fix compilation issues in tests after trunk merge * AMBARI-22797. The stup-ldap tool should persists its output into Ambari database rather than ambari.properties * AMBARI-22797. Better CLI option names * AMBARI-22797. Dot not filter for PAM only; we should inform the end user when configuring LDAP in case the currently cond=figured auth method is not LDAP * AMBARI-22797. Removed redundant information from the JSON payload * AMBARI-22797. Removing 'is_root' check from setup-ldap (according to R. Levas this is irrelevant) * AMBARI-22797. Fixed error message * AMBARI-22797. Created constants to avoid typos * AMBARI-22797. Removed redundant constant (one already existed with the same value) * AMBARI-22797. Fixed CLI option names under Windows * AMBARI-22712. Update install Wizard layout. Second patch. (akovalenko) * AMBARI-22776 Ambari Blueprint 3.0/3.1 database tables and JPA objects + DDL cleanup (#109) (benyoka) * AMBARI-22776 Blueprint 3.0 Database schemas and JPA objects, DDL fixes (benyoka) * AMBARI-22776 Revert accidental commit (benyoka) * AMBARI-22776 Revert accidental change #2 (benyoka) * AMBARI-22776 Fix review findings (benyoka) * AMBARI-22776 Fix review findings #2 (benyoka) * AMBARI-22776 remove blueprint -> stack reference, docs (benyoka) * AMBARI-22776 fix build issues (benyoka) * AMBARI-22776 Add MpackInstanceEntity -> MpackEntity reference (benyoka) * [AMBARI-22817] Update backend code to handle new versioning schema. (#155) * AMBARI-22817. Update backend code to handle new versioning schema.(vbrodetskyi) * AMBARI-22817. Update backend code to handle new versioning schema.(vbrodetskyi) * AMBARI-22817. Update backend code to handle new versioning schema.(vbrodetskyi) * AMBARI-22817. Update backend code to handle new versioning schema.(vbrodetskyi) * AMBARI-22817. Update backend code to handle new versioning schema.(vbrodetskyi) * AMBARI-22817. Update backend code to handle new versioning schema.(vbrodetskyi) * AMBARI-22805. Improve Blueprints error handling in case of timeout (#185) * [AMBARI-22815] Change requiredServices in metainfo xml (#181) * AMBARI-22815 Change requiredServices in metainfo.xml (dsen) * AMBARI 22815 Change requiredServices in metainfo xml (renamed scope to dependencyType) (dsen) * AMBARI-22572. During cluster installation bower cannot resolve angularjs version (alexantonenko) * AMBARI-22572. During cluster installation bower cannot resolve angularjs version (angular version changed) (alexantonenko) * AMBARI-22776 Fix DDL issues resulting from incomplete table rename (benyoka) (#189) * AMBARI-22776 Fix DDL issues resulting from incomplete table rename (benyoka) * AMBARI-22776 More DDL fixes and renamings in the code (benyoka) * AMBARI-22413 fix tar_archive.archive_directory_dereference (benyoka) (#195) * AMBARI-22846. Get rid of Murmur Hash usage in Log Feeder for log events * AMBARI-22799 - define scheduling of archiving Infra Solr Documents * AMBARI-22840 Standardize precision when expressing durations * AMBARI-22782. Fix Namenode alerts broken due to enabling federation (aonishuk) * AMBARI-22853. NFS Gateway is not logging at the correct location (aonishuk) * AMBARI-22851 Host Details page style fixes * AMBARI-22861. Ambari UI for Scheduler configuration is trimming = from value sets * AMBARI-22862. Ambari admin breaks cause of responseInterceptors property * AMBARI-22861. Ambari UI for Scheduler configuration is trimming = from value sets (log removed) * [AMBARI-22845] Update service metainfo schema (#194) * AMBARI-22845 Update service metainfo schema (dsen) * AMBARI-22845 Update service metainfo schema - changes according to review (dsen) * AMBARI-22561. Need to address HDP-GPL repo update after user accepts license in post-install scenario (aonishuk) * AMBARI-22855. Log Search: using shipperconfig api should be configurable * AMBARI-22824. Let YARN/MR2 use ZK principal name set by users when enabling Kerberos (until now it's been hardcoded to 'zookeeper') * AMBARI-22847. Let HBase use ZK principal name set by users when enabling Kerberos (until now it's been hardcoded to 'zookeeper') * AMBARI-22860. Support external zookeeper for Infra Solr and Log Search * AMBARI-22866. Log Search: Add userList query for audit log requests. * AMBARI-22867 Add new state for Not Available data in Heatmap widget * AMBARI-22712. Update install Wizard layout. Third patch. (akovalenko) * [AMBARI-22858] First prereq not displaying for Free IPA method in Enable Kerberos Wizard * AMBARI-22791 support for parsing MulitE blueprints and cluster templates (#213) * AMBARI-22776 Blueprint 3.0 Database schemas and JPA objects, DDL fixes (benyoka) * AMBARI-22776 Revert accidental commit (benyoka) * AMBARI-22776 Revert accidental change #2 (benyoka) * AMBARI-22776 Fix review findings (benyoka) * AMBARI-22776 Fix review findings #2 (benyoka) * AMBARI-22791-Update blueprint object and convert from entity (benyoka) * AMBARI-22791-BlueprintFactory and tests (benyoka) * AMBARI-22791 Can store and retrieve multi-instance blueprint * AMBARI-22791 Build and unit test fixes (benyoka) * AMBARI-22791 merge branch-feature-AMBARI-14714 and fixes (benyoka) * AMBARI-22791 fix unit test failure (benyoka) * AMBARI-22791 fix import error (benyoka) * AMBARI-22791 Multi-everythin cluster template support (benyoka) * AMBARI-22791 fix review findings (benyoka) * AMBARI-22873: Remove HDP 3.0 stack from Ambari (jluniya) * AMBARI-22865. Moving out get_service_component_meta to DefaultStackAdvisor so that all children can use this function * AMBARI-22878: Update Service Group API to take list of mpack name associated with the service group * AMBARI-22869. Log Search: use default page and pageSize to log requests (+ rename shipper config api key name) * AMBARI-22874. Log Search: Return with 500 error for shipper config testing if an exception occurred. * AMBARI-22879 Ambari makes unrelated changes to zookeeper quorum config in all services when delete host action fails * AMBARI-20908 : Kafka advertised.listeners replaced in Kerberos Mode (bharatviswa via mradhakrishnan) * [AMBARI-22876] Disable consecutive authentication failure account lockout feature by default * [AMBARI-22882] Long cannot be cast to String error when changing a user's password * AMBARI-22841. Fix upgrade-catalog after accordingly to kerberos changes(echekanskiy) * [AMBARI-22881] Added user_authentication_id_seq into ambari_sequences upon upgrade to 2.7 * AMBARI-22881. Added user_authentication_id_seq into ambari_sequences upon upgrade to 2.7 * AMBARI-22881. Introduced a new function to fetch the maximum value of an ID column * AMBARI-22881. Using constant instead of hard-coded value * AMBARI-22830. Ambari-agent puts Python scripts in 2.6 directory on OSes that use python 2.7.x by default (aonishuk) * AMBARI-22893: Update rat check rules for stack files (jluniya) * AMBARI-22864. Agent commands hang even after freeing up disk space on the host (aonishuk) * [AMBARI-22712] Update install Wizard layout. Fourth patch. (#247) * AMBARI-22712. Update install Wizard layout. Fourth patch. (akovalenko) * AMBARI-22712. Update install Wizard layout. Fourth patch. (akovalenko) * AMBARI-22884. LogSearch Integration should call newer API to obtain log file metadata. * [AMBARI-22888] Cancel operation during package deployment causing repository manager to be broken (dgrinenko) * AMBARI-22890. LogSearch Integration support for external Shared LogSearch Server connections. * [AMBARI-22875] Blueprint cluster creation using manually installed mpacks (#231) * AMBARI-22878: Update Service Group API to take list of mpack name associated with the service group * [AMBARI-22885] LDAP sync fails with 'LDAP is not configured' error after configuring LDAP * AMBARI-22885. We fetch 'ldap enabled' flag from both ambari.properties (to support backward compatibility) and from AMBARI DB via our REST API * AMBARI-22885. Make sure we close response (even if an error occurred) * AMBARI-22885. Retrieving the 'is LDAP enabled' flag from AMBARI DB is enough (do not need to search it in ambari.properties) * AMBARI-22900 Log Search UI: implement 'History' functionality * AMBARI-22614. Fix some unit tests * [AMBARI-22889] LDAP configuration is not reloaded in Guice * AMBARI-22889. Make sure that the latest configuration is used when populating LDAP data * AMBARI-22889. LDAP authentication provider aos uses configuration provider instead of the configuration directly * AMBARI-22889. Fixed Python unit tests (not related to my changes) * AMBARI-22835 Log Search UI: implement log level filter * AMBARI-22905. Supporting old CLI option names in setup-ldap tool * AMBARI-22909 Log Search UI: implement filter by username for access logs * AMBARI-22712. Update install Wizard layout. Fifth patch. (akovalenko) * AMBARI-22911 Log Search UI: move Capture button to top menu * AMBARI-22912 Host details page: components not reconfigured after deleting their host * [AMBARI-22914] Oracle DDL is broken at trunk * [AMBARI-22886] Infra Manager: store s3 credentials in Hadoop credential store (#261) * AMBARI-22886 Infra Manager: store s3 credentials in Hadoop credential store * AMBARI-22886 Infra Manager: store s3 credentials in Hadoop credential store - addendum: use Optional<String> as a return type of getPassword, remove unnecessary ArrayList * AMBARI-22915 Dashboard-Metrics page style edits * [AMBARI-22910] Add Ambari admin/pw CLI options for setup-ldap tool * AMBARI-22910. Supporting Ambari admin user/pw CLI options in setup-ldap tool * AMBARI-22910. Using more generic option names for Ambari username/password * AMBARI-22917. Log Search make logsearch maven build to independent from other modules * AMBARI-22903. Log Search: Add Knox to docker dev env (#265) * AMBARI-22903. Log Search: Add Knox to docker dev env * AMBARI-22890. Use quotes for checking bash variables * AMBARI-22833 : change commons-collections-3.2.1.jar being used by ambari views to commons-collections-3.2.2.jar (nitirajrathore) (#188) merging as changes are approved * AMBARI-22921. Unable to enable hive interactive, LLAP, on our Ambari 2.5.2 managed cluster (aonishuk) * [AMBARI-22913]. Add ability to MasterHostResolver to resolve by namespa… (#269) * AMBARI-22913. Add ability to MasterHostResolver to resolve by namespace at a time (amagyar) * AMBARI-22913. Add ability to MasterHostResolver to resolve by namespace at a time (amagyar) * AMBARI-22902. Changed description of Kadmin Host * [AMBARI-22904] Revised mpack APIs (#252) * [AMBARI-22904] Revised mpack APIs * [AMBARI-22904] Revised mpack APIs * [AMBARI-22904] Revised mpack APIs * [AMBARI-22904] Revised mpack APIs * [AMBARI-22904] Revised mpack APIs * [AMBARI-22904] Revised mpack APIs * [AMBARI-22904] Revised mpack APIs * [AMBARI-22854] Fix running service checks with new mpack definitions (#204) * AMBARI-22854 Fix running service checks with new mpack definitions (dsen) * AMBARI-22854 Fix running service checks with new mpack definitions - removed obvious javadocs (dsen) * Merge trunk into branch-feature-AMBARI-14714 * Branch feature ambari 14714 (#291) * [AMBARI-22904] Revised mpack APIs * [AMBARI-22904] Revised mpack APIs * [AMBARI-22904] Revised mpack APIs * [AMBARI-22904] Revised mpack APIs * [AMBARI-22904] Revised mpack APIs * [AMBARI-22904] Revised mpack APIs * [AMBARI-22904] Revised mpack APIs * [AMBARI-22904] Revised mpack APIs - Fix for dependencyType -> Type in ModuleDependency class. * Branch feature ambari 14714 (#307) * [AMBARI-22948] stack-hooks has to be updated to use cluster-settings instead of cluster-env * [AMBARI-22938] Fix SQL issue due to trunk merge issue * AMBARI-22971: Remove current_mpack_id to mpack_id in stacks table (jluniya) * AMBARI-22971: Remove current_mpack_id to mpack_id in stacks table (jluniya) * [AMBARI-22957] Stack Metainfo.xml should contain the osSpecifics tag * [AMBARI-22980] Commenting out stack_features and stack_select calls until instance_manager is ready * [AMBARI-22980] Issue warnings when stack select tool is not present * [AMBARI-22995] Remove deprecated Upgrade Packs * [AMBARI-22992] Update error handling during mpack installation (#363) * [AMBARI-22992] Update error handling during mpack installation * [AMBARI-22997] cluster-settings.xml is not present in /var/lib/ambari-server/resources post ambari installation * [AMBARI-22992] Update error handling during mpack installation - review comments * [AMBARI-22980] Correct the name of the repo_suse_rhel_template * [AMBARI-23036] Create Lifecycle changes for Upgrade Packs (#430) * [AMBARI-23036] Create Lifecycle changes for Upgrade Packs * [AMBARI-23036] Update new enum for ordering (review comments) * [AMBARI-23004] Create initial version of InstanceManager to create instance layout (dsen) * Changes according to the review + general improvements * [AMBARI-23004] Create initial version of InstanceManager to create instance layout - additional fix (dsen) (#441) * AMBARI-22649. settings library should convert true/false to boolean * AMBARI-22979: Update software registry API to support new mpack schema (jluniya) (#433) * [AMBARI-22883] A new REST API: GET /api/v1/hosts?format=summary or /api/v1/clusters/… (#285) * A new REST API: GET /api/v1/hosts?format=summary or /api/v1/clusters/{cluster_name}/hosts?format=summary is supported with this implementation and return the number of hosts running each possible operating system. More aggregation info of hosts can be also added in this code structure. * A new REST API: GET /api/v1/hosts?format=summary or /api/v1/clusters/{cluster_name}/hosts?format=summary is supported with this implementation and return the number of hosts running each possible operating system. More aggregation info of hosts can be also added in this code structure. (Rebased) * A new REST API: GET /api/v1/hosts?format=summary or /api/v1/clusters/{cluster_name}/hosts?format=summary is supported with this implementation and return the number of hosts running each possible operating system. More aggregation info of hosts can be also added in this code structure. (Rebased) * [AMBARI-23053] Rename NON-ROLLING to EXPRESS * AMBARI-22995. Remove deprecated Upgrade Packs - after reintroduced by later merge commit * AMBARI-22883. NPE in HostResourceDefinition (#458) * AMBARI-22878. Fix unit tests broken by reference to non-existent stack (#449) * AMBARI-22614 fix some unit tests (benyoka) (#461) * AMBARI-22614 fix some unit tests (benyoka) * AMBARI-22614 fix some unit tests / remove unused import (benyoka) * AMBARI-22878. Fix unit tests (#473) * Few more unit test fixes (#486) * AMBARI-22244 * AMBARI-22854 * AMBARI-22883 * AMBARI-22904 * [AMBARI-22854] Fix running service checks with new mpack definitions - UT fix (dsen) (#495) * [AMBARI-22854] Fix running service checks with new mpack definitions - UT fix (dsen) * [AMBARI-22854] Fix running service checks with new mpack definitions (dsen) - addendum * AMBARI-22875. Use mpacks specified in cluster creation request (#444) * AMBARI-22875. Fix unit tests (#507) * [AMBARI-23032] fix exceptions, export cluster settings and single mpack (#431) * AMBARI-23032 fix execptions, export cluster settings and single mpacks (benyoka) * AMBARI-23032 fix review comments (benyoka) * AMBARI-23032 better method naming (benyoka) * AMBARI-23032 fix review comments #2 (benyoka) * AMBARI-23032 fix review comments #3 (benyoka) * AMBARI-23032 fix swallowed exceptions during mpack installation * AMBARI-22875. Exclude generated sources from checkstyle (#512) * AMBARI-23107 - Deprecate Repo Versions And Start Tracking Repo OS's F… (#515) * AMBARI-22875. Add missing license (#519) * AMBARI-22883. Count of each OS type is always 1 (#516) * [AMBARI-23121] Fix few instance manager issues found during ZK deploment (dsen) (#518) * [AMBARI-23121] Fix few instance manager issues found during ZK deployment (dsen) * [AMBARI-23121] Fix few instance manager issues found during ZK deployment (dsen) - changes according to review * [Ambari 23125] Move check-properties XML (#521) * AMBARI-23125. Move check-properties XML * AMBARI-23125. Fixed for extraneous code * AMBARI-23053. Fix unexpected indent in kafka_broker.py (#535) * AMBARI-22883. Let HostSummaryRenderer add Hosts/os_type property to the query (#539) * AMBARI-22945. Enhance host components API to support multiple host component instances. * [Ambari 23133] Hooks scripts has hadoop specific code * [AMBARI-23120] Create helper functions for using new instance manager library from the agent scripts (dsen) (#517) * [AMBARI-23120] Create helper functions for using new instance manager library from the agent scripts (dsen) * [AMBARI-23120] Create helper functions for using new instance manager library from the agent scripts (dsen) - changes according to review * [AMBARI-23120] Create helper functions for using new instance manager library from the agent scripts (dsen) - import fix (#560) * AMBARI-23147 - Expose Repository CRUD via the Mpack Endpoint (#552) * AMBARI-23158. Fix NPE in Host Components query. * [AMBARI-23130] Persist cluster creation request (#559) * AMBARI-23130 persist raw cluster provision request and extract stack ids on server restart (benyoka) * AMBARI-23130 add columnt to other DDLs + fix DDLs (benyoka) * AMBARI-23130 fix review findings (benyoka) * AMBARI-22614 fix OrmTestHelper to support mpacks in unit tests (benyoka) (#569) * AMBARI-23156. Remove Required Group Name and Expose Lifecycle to API * AMBARI-23167 - StackOverflowError thrown during cluster creation * [AMBARI-23170] Instance manager json output should have the same structure for both client and server modules (dsen) * AMBARI-23175. Fix for PUT Host Component API failing because validation check fails. * AMBARI-23176 - Some Minor Fixes For Failing Tests Due to Repo Version Refactor (#587) * [AMBARI-22875] Adopt changes in Host Component API for Blueprint cluster creation (#581) * [AMBARI-23177] Yarn-MR separation and minor deployment fixes (#588) * [AMBARI-23177] Yarn-MR separation and minor deployment fixes * Review comments * Review comments * AMBARI-23183. Revert UI changes made to branch : branch-feature-AMBARI-14714. * [Ambari-22990] Provide Bootstrap test connection feature (#530) * [Ambari-22990] Provide Bootstrap test connection feature * [Ambari-22990] Provide Bootstrap test connection feature * Add newline to avoid audit failures

AMBARI-23032 fix execptions, export cluster settings and single mpack…

63083ec

…s (benyoka)

benyoka added the blueprint label Feb 21, 2018

benyoka self-assigned this Feb 21, 2018

benyoka requested review from adoroszlai, rnettleton and swapanshridhar February 21, 2018 16:17

adoroszlai suggested changes Feb 21, 2018

View reviewed changes

adoroszlai reviewed Feb 21, 2018

View reviewed changes

Balazs Bence Sari added 2 commits February 22, 2018 12:59

AMBARI-23032 fix review comments (benyoka)

4ec0391

AMBARI-23032 better method naming (benyoka)

bd2f0b3

adoroszlai approved these changes Feb 22, 2018

View reviewed changes

Balazs Bence Sari added 2 commits February 22, 2018 14:33

AMBARI-23032 fix review comments apache#2 (benyoka)

33c0f20

AMBARI-23032 fix review comments apache#3 (benyoka)

aba404a

Balazs Bence Sari added 2 commits February 26, 2018 11:14

Merge remote-tracking branch 'upstream/branch-feature-AMBARI-14714' i…

c31829c

…nto AMBARI-23032-branch-feature-AMBARI-14714

AMBARI-23032 fix swallowed exceptions during mpack installation

91f1560

adoroszlai changed the title ~~AMBARI-23032 fix execptions, export cluster settings and single mpack…~~ [AMBARI-23032] fix exceptions, export cluster settings and single mpack Feb 26, 2018

rnettleton approved these changes Feb 28, 2018

View reviewed changes

Merge branch 'branch-feature-AMBARI-14714' into AMBARI-23032-branch-f…

eb370a6

…eature-AMBARI-14714

benyoka merged commit e809633 into apache:branch-feature-AMBARI-14714 Mar 1, 2018

benyoka deleted the AMBARI-23032-branch-feature-AMBARI-14714 branch March 1, 2018 13:59

[AMBARI-23032] fix exceptions, export cluster settings and single mpack #431

[AMBARI-23032] fix exceptions, export cluster settings and single mpack #431

Uh oh!

Conversation

benyoka commented Feb 21, 2018

How was this patch tested?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

asfgit commented Feb 21, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

asfgit commented Feb 22, 2018

Uh oh!

asfgit commented Feb 22, 2018

Uh oh!

asfgit commented Feb 22, 2018

Uh oh!

asfgit commented Feb 26, 2018

Uh oh!

asfgit commented Feb 26, 2018

Uh oh!

rnettleton left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

asfgit commented Mar 1, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants