Skip to content

AMBARI-26204: Migrate RecommendationResourceProviderTest from EasyMoc… #3860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JiaLiangC merged 2 commits into from
Oct 28, 2024
Merged

AMBARI-26204: Migrate RecommendationResourceProviderTest from EasyMoc… #3860

JiaLiangC merged 2 commits into from
Oct 28, 2024

Conversation

@JiaLiangC
Copy link
Contributor

@JiaLiangC JiaLiangC commented Oct 26, 2024

…k to Mockito

What changes were proposed in this pull request?

Migrate RecommendationResourceProviderTest from EasyMock to Mockito

Description

This PR migrates the RecommendationResourceProviderTest class from EasyMock to Mockito testing framework. This change is necessary to resolve compatibility issues when running tests under JDK 17.

Changes

  • Replaced EasyMock imports with Mockito imports
  • Updated testCreateConfigurationResources and testCreateNotConfigurationResources methods to use Mockito syntax
  • Refactored the testCreateResources helper method to use Mockito
  • Removed EasyMock dependency (if previously present)

Key Error Resolved

This PR addresses the following error that occurred after upgrading to JDK 17:

[ERROR] org.apache.ambari.server.controller.internal.RecommendationResourceProviderTest.testCreateConfigurationResources -- Time elapsed: 0.761 s <<< ERROR!
java.lang.ClassCastException: class jdk.proxy2.$Proxy42 cannot be cast to class [Ljava.lang.Object; (jdk.proxy2.$Proxy42 is in module jdk.proxy2 of loader 'app'; [Ljava.lang.Object; is in module java.base of loader 'bootstrap')

Possible Reasons for the Error

The error likely occurs due to changes in how JDK 17 handles dynamic proxies compared to JDK 8:

  1. Module System: JDK 17 uses a stronger module system, which can affect how classes from different modules interact.
  2. Proxy Implementation: The way proxies are implemented has changed in JDK 17, leading to incompatibilities with older mocking frameworks.
  3. Class Loader Differences: The error message indicates a mismatch between class loaders, which is more strictly enforced in JDK 17.
  4. EasyMock Compatibility: EasyMock may not be fully compatible with JDK 17, especially when it comes to creating proxies for array types.

Migrating to Mockito, which is actively maintained and compatible with JDK 17, should resolve these issues.

How was this patch tested?

  • unit tests have been updated and pass
    image

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Ambari Contributing Guide before opening a pull request.

@JiaLiangC
Copy link
Contributor Author

JiaLiangC commented Oct 26, 2024

@virajjasani Could you help review this pr?

@JiaLiangC JiaLiangC merged commit 4c3d8bd into apache:upgrade/jdk-spring-dependencies Oct 28, 2024
@JiaLiangC JiaLiangC deleted the AMBARI-26204 branch November 6, 2024 06:28
JiaLiangC added a commit that referenced this pull request Dec 27, 2024
@JiaLiangC
AMBARI-26204: Migrate RecommendationResourceProviderTest from EasyMoc… (
5bc4728 
#3860)

* AMBARI-26204: Migrate RecommendationResourceProviderTest from EasyMock to Mockito
JiaLiangC added a commit that referenced this pull request Feb 6, 2025
@nikita15p @guluo2016
@sandeep318kumar @zRains @coldless177 @JiaLiangC @yaruyng @itongxiaojun @vishalsuvagia
AMBARI-26303: Rebase trunk branch onto frontend-refactor (#3937)
982c545 
* AMBARI-26232 There will be failure when executing shell.py and wrong order of imports for WidgetResourceProvider.java (#3872)

* There will be failure when executing shell.py
* Wrong order of imports for WidgetResourceProvider.java
* Fix issue of test failure

* AMBARI-26234: ClusterNotFoundException in stage Confirm Hosts during deploying a cluster #3875

* AMBARI-26184: Resolve snakeyaml 1.12 CVE #3869

* AMBARI-26235: Unable to check firewalld status when setup ambari #3878

* AMBARI-26195: Ambari database page not wokring after JQ upgrade #3885

* AMBARI-26239: Fix OozieUtils (#3894)

* AMBARI-26239: Fix OozieUtils

* AMBARI-26205: Dropdown menu flex layout overflow #3895

* AMBARI-26236: The database password character type requirement is too few (#3883)

* The database password character type requirement is too few
* Add more special characters, and add UT for this case
* Update test case

* AMBARI-26240: Fix alter dispatcher (#3896)

* AMBARI-26241: _threadlocal has no uid because it is always None #3898

* AMBARI-26243: refactor: convert .format() to f-strings #3899

* AMBARI-26244: convert .format() to f-strings for ambari-server #3901

* AMBARI-26245: refactor(ambari-agent): convert .format() to f-strings (#3902)

* AMBARI-26249: Timeline Service v2 failed to start because of unable to create leveldb state store directory #3905

* AMBARI-26247: convert .format() to f-strings for ambari-contrib #3903

* Update the KEYS File

* AMBARI-26253: Can't download all client configs (#3906)

* AMBARI-26257: Create new Configuration Group now worked #3907

* AMBARI-26248: Timeline Service Reader failed to start if hbase is not installed #3904

* AMBARI-26147: Add Ruff integration to ambari  (#3908)

* add ruff check files
* add formatted code

* AMBARI-26251: tooltip display issue #3911

* AMBARI-26207: Metrics sortable not work #3912

* AMBARI-26255: fix can't add capacity-scheduler views (#3913)

* AMBARI-26270: Add quicklink of hiveserver2 web ui #3918

* AMBARI-26142: JDK17 support for Ambari Co-authored-by: Mohammad Arshad <[email protected]> (#3851)

* AMBARI-26204: Migrate RecommendationResourceProviderTest from EasyMoc… (#3860)

* AMBARI-26204: Migrate RecommendationResourceProviderTest from EasyMock to Mockito

* AMBARI-26203: Fix annotation processing issue in ConfigurationTest after JDK 17 upgrade (#3859)

* AMBARI-26203: Fix testAllPropertiesHaveMarkdownDescriptions failed

* AMBARI-26212: Fix checkstyle error (#3862)

* Ambari-26211: Fix TaskActionScheduler test failed (#3861)

* AMBARI-26211: Fix TaskActionScheduler test failed

* AMBARI-26215: Fix BlueprintConfigurationProcessorTest and others (#3863)

* AMBARI-26215: Fix BlueprintConfigurationProcessorTest and others

* AMBARI-26220: Fix ConfigureClusterTaskTest Unexpected method calls: ClusterConfigurationRequest.getRequiredHostGroups() error (#3864)

fix AsyncCallableServiceTest Unexpected method calls: Callable.call() error

* AMBARI-26221: Fix StackAdvisorCommandTest error，remove unnecessary code. (#3865)

* AMBARI-26222: Fix ClientConfigResourceProviderTest & PreUpgradeCheckResourceProviderTest& ExecutionSchedulerTest& AmbariProxiedUserDetailsServiceTest

* AMBARI-26233: Fix ambari-env.sh after jdk upgrade (#3873)

* fix ambari agent env after jdk upgrade

* AMBARI-26238: Add Ambari Java Home configuration for JDK 17 in Ambari… (#3891)

* AMBARI-26238: Add Ambari Java Home configuration for JDK 17 in Ambari server

* AMBARI-26268: Remove default value for ambari-java-home in ambari-server.py to fix setup handling #3915

Co-authored-by: tongxiaojun <[email protected]>

* AMBARI-26269: Fix regex pattern flag position in ambari_jinja2 filters #3917

* AMBARI-26269: Fix regex pattern flag position in ambari_jinja2 filters
---------

Co-authored-by: tongxiaojun <[email protected]>

* AMBARI-26249: Addendum, adjusting the location of creating directory code (#3920)

* AMBARI-26271: Invalid parameter was provided when using shell.call in HostInfo.py #3919

* AMBARI-26273: Add Oceanbase Support to Ambari MySQL DDL #3921

Co-authored-by: tongxiaojun <[email protected]>

* AMBARI-26275: NoClassesFoundToAnalyzeException when compiling ambari with jdk17 #3924

* AMBARI-25848 : Need to update org.codehaus.jackson:jackson-mapper-asl dependency (#3922)

Issue: Need to update org.codehaus.jackson:jackson-mapper-asl dependency.

Cause: the library has been moved to com.fasterxml.jackson.core » jackson-databind,
hence to keep up with the newer versions need to update the library dependency.

Changes made: to update the jackson-mapper-asl dependency to jackson-databind and the required library version upgrades

Co-authored-by: Vishal Suvagia <[email protected]>

* AMBARI-26276: fix hdfs web service check (#3925)

* AMBARI-26277:fix kerberos encryption error (#3926)

* AMBARI-26279: ambari-agent prints logs that netstat command not found #3928

* AMBARI-26286: refactor(ambari-ruff): convert .format() to f-strings #3927

AMBARI-26286: refactor(ambari-ruff): convert .format() to f-strings

* AMBARI-26055: Add alluxio support (#3934)

* add alluxio service

Co-authored-by: jialiang <[email protected]>

* fix license

---------

Co-authored-by: jialiang <[email protected]>

* AMBARI-26185: Upgrade commons-collections to resolve CVEs (#3936)

---------

Co-authored-by: Peng Lu <[email protected]>
Co-authored-by: Sandeep  Kumar <[email protected]>
Co-authored-by: zrain <[email protected]>
Co-authored-by: coldless177 <[email protected]>
Co-authored-by: jialiang <[email protected]>
Co-authored-by: yaruyng <[email protected]>
Co-authored-by: tongxiaojun <[email protected]>
Co-authored-by: tongxiaojun <[email protected]>
Co-authored-by: Vishal Suvagia <[email protected]>
Co-authored-by: Vishal Suvagia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@virajjasani virajjasani virajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JiaLiangC @virajjasani