[AMBARI-22996] ViewInstanceResourceProviderTest, ViewPermissionResourceProviderTest, and ViewURLResourceProviderTest fail unexpectedly #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceProviderTest, and ViewURLResourceProviderTest.
|
Refer to this link for build results (access rights to CI server needed): |
adoroszlai
reviewed
Feb 19, 2018
|
|
||
| @Before | ||
| public void before() { | ||
| ViewRegistry.initInstance(viewregistry); |
Contributor
There was a problem hiding this comment.
Do we still need the static init?
Contributor
Author
There was a problem hiding this comment.
You are correct, the static block is no longer necessary. I have therefore removed it from all three classes, and all tests in these classes still pass.
…tanceResourceProviderTest, ViewPermissionResourceProviderTest, and ViewURLResourceProviderTest.
|
Refer to this link for build results (access rights to CI server needed): |
adoroszlai
approved these changes
Feb 20, 2018
rlevas
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
These tests require that a mocked ViewRegistry be used, which is set in a static initializer block. If the ViewRegistry is set after that, for example, but running a test in one of these classes, then the tests will no longer be using the correct ViewRegistry. Therefore, I have changed the set up methods of these test classes to set the ViewRegistry to the mocked version from that class.
How was this patch tested?
Patch was tested manually.
@adoroszlai @rlevas This pull request fixes an issue similar to others I have submitted in the past (#176 and #133).