AMBARI-25569 Reassess Ambari Metrics data migration #3242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I5754c9187a8786e9a3e2ae753174519b46777d45
ghost
approved these changes
Oct 12, 2020
Author
|
@sziszo Could you please review this PR ? Thx! |
Change-Id: Id042aaa2d5d47107ba2629af1c40105600f2f0df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The data migration code only looks for the metrics that are present in the whitelist file. This is true even in the case when the AMS Whitelisting is not enabled. The user will only have those metrics migrated that are present in the whitelist file, which is usually not all that are required.
The proposed change no 1:
migrate only the metrics that are in the whitelist file
The proposed change no 2:
Furthermore, the migration process frequently dies silently while saving the metadata. To fix this, the change suggests removing the initiating of saving metadata from the shutdown hook and call it "normally" in a finally block.
The proposed change no 3:
Code cleanup.
How was this patch tested?
The patch was tested by manual data migrations.