Skip to content

[AMBARI-22837] AmbariAuthorizationFilterTest.testDoFilter_userNoPermissionsAccess fails unexpectedly #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlevas merged 4 commits into from
Feb 14, 2018
Merged

[AMBARI-22837] AmbariAuthorizationFilterTest.testDoFilter_userNoPermissionsAccess fails unexpectedly #176

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2610b02
Fixed dependent test: AmbariAuthorizationFilterTest.testDoFilter_user…
ReedOei Jan 23, 2018
fd11db6
Merge remote-tracking branch 'upstream/trunk' into trunk
ReedOei Jan 23, 2018
e226334
Merge remote-tracking branch 'upstream/trunk' into trunk
ReedOei Jan 26, 2018
95aad2f
AMBARI-22837. Remove mocked SecurityContext in AmbariAuthorizationFil…
ReedOei Jan 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...t/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
import org.apache.ambari.server.view.ViewRegistry;
import org.easymock.EasyMock;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.springframework.security.core.Authentication;
import org.springframework.security.core.context.SecurityContext;
Expand All @@ -60,6 +61,11 @@
import junit.framework.Assert;

public class AmbariAuthorizationFilterTest {
@Before
public void setUp() {
SecurityContextHolder.getContext().setAuthentication(null);

@rlevas rlevas Jan 24, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, this is not the correct solution since the test case appears to use a mocked SecurityContext, not the one from the SecurityContextHolder. See org.apache.ambari.server.security.authorization.AmbariAuthorizationFilterTest#performGeneralDoFilterTest.

I think we need to remove the mocked SecurityContext and use the one provided by Spring. For example, see org.apache.ambari.server.controller.internal.UserResourceProviderTest#deleteResourcesTest.

In cases like the referenced method, we can do the following rather than create a mocked SecurityContext:

    SecurityContextHolder.getContext().setAuthentication(authentication);

Since the test case explictly sets the authenticated user before performing the test, there is no real need to explicitly clear it in the before method.

}

@After
public void clearAuthentication() {
SecurityContextHolder.getContext().setAuthentication(null);
Expand Down