-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[AMBARI-22815] Change requiredServices in metainfo.xml #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMBARI-22815] Change requiredServices in metainfo.xml #153
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
| <service>HDFS</service> | ||
| <service> | ||
| <name>HDFS</name> | ||
| <scope>INSTALL</scope> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename "scope" to "type" or "dependencyType"? We might end up adding scope in the future to scope to HOST,CLUSTER etc.
| </service> | ||
| <service> | ||
| <name>HDFS</name> | ||
| <scope>INSTALL</scope> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep a type=LEGACY for old stack definitions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary, since for old stacks the LEGACY will be the same as the INSTALL type
mradha25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to change all the metainfo.xml here, considering it will be reworked by the module teams and we will not be using common-services?
|
@mradha25 this is needed as long as we support the old stacks, but when we move to only modules architecture old files will be deleted |
|
Created new PR from the forked repo : #181 |
* ODP-2577: kafka mirrormaker2 observability for jmx port * ODP-2577: kafka mirrormaker2 observability for jmx port * ODP-2577: kafka mirrormaker2 observability for jmx port-v2 --------- Co-authored-by: Shubham Sharma <shubham@acceldata.io>
Change requiredServices in metainfo.xml
Today we define requiredServices as follows
ZOOKEEPER
In the mpack model we need to categorize the scope of service dependency. We could have an INSTALL time dependency (i.e. we should also install the dependent service) or a RUNTIME dependency (i.e. there should be a running instance of the service in the cluster).
For example HIVE in EDW mpack, will have an install-time dependency on ZOOKEEPER-CLIENT but a RUNTIME dependency on ZOOKEEPER.
ZOOKEEPER-CLIENT
INSTALL
ZOOKEEPER
RUNTIME
Patch was tested manually and with UT